Open
Conversation
The following pip command should work: pip install git+https://github.com/TheFel0x/img2braille.git This installs the main executable as `img2braille`.
Contributor
Author
|
OK, then I will convert this draft pull request to a regular pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since PR #7 still seems to be in the early draft stage, I would like to suggest another path to turn this program into a package. This PR allows the program to be installable via pip (or pipx) from GitHub:
with fairly small changes, though it is not designed to be used as a library module.
(To make it installable from PyPI, you still need to upload it.)
The idea is basically to bundle a single file package (famous example:
six). Becausescript.pyis too general for a unique name, I renamed it toimg2braille.py.pyproject.tomlcontains the package information (you need to review author information, etc).The
main"function" is added toimg2braille.pyfor the main entry point of the executable (the whole program code is executed whenimg2brailleis imported).The following commands shows what happens (using my branch for now):
python3 -m venv .venv . .venv/bin/activate pip install git+https://github.com/tueda/img2braille.git@minimal-packaging img2braille -hI think this PR can be merged if @GideonBear agrees (I have marked it as "Draft" for now).