Skip to content

Fix not being able to interact with pocket with full offhand #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NoYavy wants to merge 2 commits into
base: 1.21.1-neoforge
Choose a base branch
from
Open

Fix not being able to interact with pocket with full offhand #130

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
52b5f04
Pocket now forces interaction with itself, even if player is holding …
NoYavy Dec 17, 2025
0083c96
included wall edges
NoYavy Dec 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion src/main/java/com/tcn/dimensionalpocketsii/core/management/PocketsGameEventsManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,15 +37,18 @@
import net.minecraft.world.item.component.CustomData;
import net.minecraft.world.level.Level;
import net.minecraft.world.level.LevelAccessor;
import net.minecraft.world.level.block.Block;
import net.minecraft.world.level.dimension.BuiltinDimensionTypes;
import net.minecraft.world.level.dimension.DimensionType;
import net.neoforged.api.distmarker.Dist;
import net.neoforged.api.distmarker.OnlyIn;
import net.neoforged.bus.api.SubscribeEvent;
import net.neoforged.fml.common.EventBusSubscriber;
import net.neoforged.neoforge.client.event.InputEvent.Key;
import net.neoforged.neoforge.common.util.TriState;
import net.neoforged.neoforge.event.entity.living.LivingEquipmentChangeEvent;
import net.neoforged.neoforge.event.entity.player.PlayerEvent;
import net.neoforged.neoforge.event.entity.player.PlayerInteractEvent;
import net.neoforged.neoforge.event.level.LevelEvent;
import net.neoforged.neoforge.network.PacketDistributor;

Expand Down Expand Up @@ -285,5 +288,18 @@ public static void onPlayerLoggedOutEvent(final PlayerEvent.PlayerLoggedOutEvent

@SubscribeEvent
public static void onPlayerLoggedInEvent(final PlayerEvent.PlayerLoggedInEvent event) { }


@SubscribeEvent
public static void onRightClickBlock(PlayerInteractEvent.RightClickBlock event) {
Block block = (event.getLevel().getBlockState(event.getPos()).getBlock());
// force use block even if hand is not empty
if (block == PocketsRegistrationManager.BLOCK_POCKET.get() ||
block == PocketsRegistrationManager.BLOCK_POCKET_ENHANCED.get() ||
block == PocketsRegistrationManager.BLOCK_WALL.get()||
block == PocketsRegistrationManager.BLOCK_WALL_EDGE.get()
) {
event.setUseItem(TriState.FALSE);
event.setUseBlock(TriState.TRUE);
}
}
}