Open
Conversation
- structured concurrency 적용
- xcconfig 파일 경로 정리
- ViewBuilder 적용
HenryVoid
approved these changes
Dec 31, 2024
| let request = ShortsDTO.List.Request(page: 0, size: 10) | ||
| let response = try await shortsClient.popularShorts(request) | ||
|
|
||
| let result = try await withThrowingTaskGroup(of: PopularShorts?.self) { group in |
Contributor
There was a problem hiding this comment.
withThrowingTaskGroup 쓰신 이유가 무엇일까요?
Contributor
Author
There was a problem hiding this comment.
여러 개의 비동기 작업을 concurrent하게 처리하기 위함입니다.
반복문 안에 await을 사용할 시 해당 작업이 끝난 후 다음 반복문이 serial하게 수행됩니다.
이를 concurrent하게 수행하고 싶어 사용해 보았습니다~
Contributor
Contributor
Author
There was a problem hiding this comment.
현재 각 난이도에 따른 레벨 표시(V1, V3 등) 값을 알기 위해 추가적인 API 호출이 필요한 상황입니다..!
형욱님이 알려주신 부분은 쇼츠 썸네일 정보를 위해 과다한 API 호출이 이루어진다는 점인 것으로 이해됩니다.
그 부분 저도 동의하고 있습니다~ API 호출을 최대한 줄이고 싶은데, 현재 쇼츠 API 구성의 한계로 인해 이렇게 구현하였습니다 ㅜㅜ
혹시 더 좋은 방법이 있을까요?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

close #19
📓 Overview
🤔 고민 내용
📸 Screenshot