dependencies fix, check for GLM with pkg-config first#4
Open
bartman wants to merge 1 commit intoTheCherno:mainfrom
Open
dependencies fix, check for GLM with pkg-config first#4bartman wants to merge 1 commit intoTheCherno:mainfrom
bartman wants to merge 1 commit intoTheCherno:mainfrom
Conversation
|
you might want to just use the fetchcontent example in the glm readme: https://github.com/g-truc/glm/blob/master/readme.md#cmake-using-fetchcontent here is another ref from documentation: at least the way it seems, the only thing we want vendored by the OS is opengl (even that gets complicated on linux with glvnd & hybrid graphics) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On my system, Linux (NixOS), Cmake was unable to find GLM, which is accessible via GLM.
However,
pkg-configworks.The patch provided, will try to use
pkg-config, thenfind_package, before falling back tofetchcontent.Hope that's acceptable.