Open
Conversation
| # ABM microcarriers | ||
|
|
||
| This software is used for the Proof of Concept project by the [CMMC](thecmmc.org). The technical report describing the proof of concept can be found [here](https://zenodo.org/record/4264611). | ||
| This software is used for the Proof of Concept project by the [CMMC](thecmmc.org). |
Member
There was a problem hiding this comment.
It seems like you did not base this branch on the most up to date master branch. For future branches it's best to do a git pull on the master branch just before you create a new branch. For now we can just put this addition in:
Suggested change
| This software is used for the Proof of Concept project by the [CMMC](thecmmc.org). | |
| This software is used for the Proof of Concept project by the [CMMC](thecmmc.org). The technical report describing the proof of concept can be found [here](https://zenodo.org/record/4264611). |
Member
|
Also when trying to run this model, (as well as the one in the master branch) it fails on a check in line 237 of This should be set to 7 as we have 7 output reals. |
JaroCamphuijsen
requested changes
Dec 8, 2020
Member
JaroCamphuijsen
left a comment
JaroCamphuijsen
left a comment
There was a problem hiding this comment.
@boaguilar Can you change the two things I mentioned? Then we can merge this! Yippee!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.