Fix handle jest v27 fake timers (issue #30)#38
Open
wilsonpage wants to merge 1 commit intoTheBrainFamily:masterfrom
Open
Fix handle jest v27 fake timers (issue #30)#38wilsonpage wants to merge 1 commit intoTheBrainFamily:masterfrom
wilsonpage wants to merge 1 commit intoTheBrainFamily:masterfrom
Conversation
The existing check for jest fake timers no longer works as jest v27 mutates the `setTimeout` global differently. This patch checks for both the old and new formats.
Member
|
Thanks, do you think this works too? #37 I like that it also upgrades the jest so the tests verify the change |
Author
👍 Looks like a better PR. You should merge that one. |
|
I can recommend an alternative if you're interested :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing check for jest fake timers no longer works as jest v27 mutates the
setTimeoutglobal differently. This patch checks for both the old and new formats.