Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes text and icon coloring in the AppBar to ensure proper contrast and consistency across theme modes by changing from Color.Surface to Color.Inherit.
Key changes:
- Changed icon color from
Color.SurfacetoColor.Inheritfor three separator icons in the AppBar - Converted HTML
<a>tag to MudBlazor<MudLink>component withColor.Inheritfor the Change Log link - Updated release date in CHANGELOG.md from "2025-xx-xx" to "2025-12-17"
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| OpenBudgeteer.Blazor/Shared/MainLayout.razor | Updated AppBar separator icons and Change Log link to use Color.Inherit instead of Color.Surface, ensuring proper color inheritance from the AppBar component |
| CHANGELOG.md | Updated version 1.11 release date to 2025-12-17 |
The changes are consistent with the existing AppBar styling patterns where other interactive elements (MudIconButton components) already use Color.Inherit. The use of Color.Inherit is appropriate for AppBar elements as it ensures they inherit the proper text color from the AppBar theme, providing correct contrast in both light and dark modes.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.