extend `ILockDealNFT` interface #114

YouStillAlive · 2025-01-30T10:34:41Z

closes #113

sonarqubecloud · 2025-01-30T10:35:06Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

github-actions · 2025-01-30T10:36:01Z

Methods

Symbol	Meaning
◯	Execution gas for this method does not include intrinsic gas overhead
△	Cost was non-zero but below the precision setting for the currency display (see options)

	Min	Max	Avg	Calls	usd avg
ERC20HelperMock
mockApproveAllowanceERC20(address,address,uint256)	-	-	51,936	1	0.04
mockTransferInToken(address,uint256)	47,479	64,579	52,365	7	0.04
mockTransferToken(address,address,uint256)	-	-	38,872	1	0.03
ERC20Token
approve(address,uint256)	45,914	45,926	45,923	4	0.03
FreeTest()	-	-	33,278	1	0.02
ERC721HelperMock
mockSetApproveForAllNFT(address,address,bool)	-	-	52,049	1	0.04
mockTransferNFTIn(address,uint256,address)	48,232	66,008	57,120	2	0.04
mockTransferNFTOut(address,uint256,address)	-	-	50,608	1	0.03
ERC721Token
approve(address,uint256)	-	-	48,339	1	0.03
awardItem(address,string)	80,723	114,983	97,833	6	0.07
setApprovalForAll(address,bool)	24,185	46,097	33,755	5	0.02
ETHHelper
switchIsPayble()	-	-	26,510	1	0.02
ETHHelperMock
mockTransferETH(address,uint256)	-	-	32,630	3	0.02
receiveETH(uint256)	-	-	22,935	3	0.02
FeeHelper
addUsers(address[],uint256[])	38,278	58,214	48,952	4	0.03
MethodWithFee()	25,956	100,310	61,295	10	0.04
removeUsers(address[])	-	-	34,849	1	0.02
setFee(address,uint256)	28,841	70,881	42,573	5	0.03
setupNewWhitelist(address)	-	-	96,067	1	0.07
withdrawFee(address,address)	36,478	41,956	39,217	2	0.03
GovManager
setGovernorContract(address)	-	-	49,685	2	0.03
PausableHelper
pause()	-	-	46,721	2	0.03
unpause()	-	-	24,680	2	0.02
PozBenefit
setGovernorContract(address)	27,545	49,685	38,615	2	0.03
setPozTimer(uint256)	25,930	30,873	28,402	2	0.02

Deployments

	Min	Max	Avg	Block %	usd avg
ArraysMock	-	-	482,341	0.4 %	0.33
CalcUtilsMock	-	-	114,043	0.1 %	0.08
ERC20HelperMock	-	-	1,057,253	0.8 %	0.72
ERC20Token	-	-	649,001	0.5 %	0.44
ERC721HelperMock	-	-	1,057,968	0.8 %	0.72
ERC721Token	-	-	911,650	0.7 %	0.62
ETHHelper	-	-	704,980	0.5 %	0.48
ETHHelperMock	-	-	903,307	0.7 %	0.61
FeeHelper	-	-	1,802,962	1.4 %	1.22
GovManager	-	-	832,956	0.6 %	0.56
NameableMock	-	-	268,254	0.2 %	0.18
PausableHelper	-	-	916,978	0.7 %	0.62
PozBenefit	-	-	901,860	0.7 %	0.61
WhiteListMock	-	-	270,673	0.2 %	0.18

Solidity and Network Config

Settings	Value
Solidity: version	0.8.27
Solidity: optimized	true
Solidity: runs	200
Solidity: viaIR	true
Block Limit	130,000,000
L1 Gas Price	1 gwei
Token Price	678.03 usd/bnb
Network	BINANCE
Toolchain	hardhat

codecov · 2025-01-30T10:36:23Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.05%. Comparing base (a86da0e) to head (f2271be).
Report is 2 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #114   +/-   ##
=======================================
  Coverage   99.05%   99.05%           
=======================================
  Files          20       20           
  Lines         212      212           
  Branches       48       48           
=======================================
  Hits          210      210           
  Misses          2        2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2025-01-30T10:37:12Z

Slither report

THIS CHECKLIST IS NOT COMPLETE. Use --show-ignored-findings to show all the results.
Summary

events-access (1 results) (Low)
missing-zero-check (4 results) (Low)
low-level-calls (1 results) (Informational)
naming-convention (82 results) (Informational)

events-access

Impact: Low
Confidence: Medium

ID-0
WhiteListHelper.setupNewWhitelist(address) should emit an event for:
- whiteListAddress = _whiteListAddress

Poolz-Helper/contracts/Fee/WhiteListHelper.sol

Lines 23 to 26 in ec8543a

    
           function setupNewWhitelist(address _whiteListAddress) external firewallProtected onlyOwnerOrGov { 
        
               whiteListAddress = _whiteListAddress; 
        
               whiteListId = IWhiteList(_whiteListAddress).CreateManualWhiteList(type(uint256).max, address(this)); 
        
           }

missing-zero-check

Impact: Low
Confidence: Medium

ID-1
FeeBaseHelper.setFee(address,uint256)._token lacks a zero-check on :
- feeToken = _token

Poolz-Helper/contracts/Fee/FeeBaseHelper.sol

Line 47 in ec8543a

    
           function setFee(address _token, uint _amount) external firewallProtected onlyOwnerOrGov {

ID-2
WhiteListHelper.setupNewWhitelist(address)._whiteListAddress lacks a zero-check on :
- whiteListAddress = _whiteListAddress

Poolz-Helper/contracts/Fee/WhiteListHelper.sol

Line 23 in ec8543a

    
           function setupNewWhitelist(address _whiteListAddress) external firewallProtected onlyOwnerOrGov {

ID-3
FeeBaseHelper.withdrawFee(address,address)._to lacks a zero-check on :
- (success,None) = _to.call{value: amount}()

Poolz-Helper/contracts/Fee/FeeBaseHelper.sol

Line 52 in ec8543a

    
           function withdrawFee(address _token, address _to) external firewallProtected onlyOwnerOrGov {

ID-4
GovManager.setGovernorContract(address)._address lacks a zero-check on :
- governorContract = _address

Poolz-Helper/contracts/GovManager.sol

Line 22 in ec8543a

    
           function setGovernorContract(address _address) external firewallProtected onlyOwnerOrGov {

low-level-calls

Impact: Informational
Confidence: High

ID-5
Low level call in FeeBaseHelper.withdrawFee(address,address):
- (success,None) = _to.call{value: amount}()

Poolz-Helper/contracts/Fee/FeeBaseHelper.sol

Lines 52 to 62 in ec8543a

    
           function withdrawFee(address _token, address _to) external firewallProtected onlyOwnerOrGov { 
        
               if (feeReserve[_token] == 0) revert FeeAmountIsZero(); 
        
               uint256 amount = feeReserve[_token]; 
        
               feeReserve[_token] = 0; 
        
               if (_token == address(0)) { 
        
                   (bool success, ) = _to.call{value: amount}(""); 
        
                   if (!success) revert TransferFailed(); 
        
               } else { 
        
                   transferToken(IERC20(_token), _to, amount); 
        
               } 
        
           }

naming-convention

Impact: Informational
Confidence: High

ID-6
Parameter ILockedDealV2.CreatePoolsWrtTime(address,uint256[],uint256[],uint256[],uint256[],address[])._FinishTime is not in mixedCase

Poolz-Helper/contracts/interfaces/ILockedDealV2.sol

Line 18 in ec8543a

uint256[] calldata _FinishTime,

ID-7
Parameter GovManager.setGovernorContract(address)._address is not in mixedCase

Poolz-Helper/contracts/GovManager.sol

Line 22 in ec8543a

    
           function setGovernorContract(address _address) external firewallProtected onlyOwnerOrGov {

ID-8
Parameter ILockedDealV2.GetMyPoolsId(address)._UserAddress is not in mixedCase

Poolz-Helper/contracts/interfaces/ILockedDealV2.sol

Line 26 in ec8543a

address _UserAddress

ID-9
Function IWhiteList.ChangeCreator(uint256,address) is not in mixedCase

Poolz-Helper/contracts/interfaces/IWhiteList.sol

Line 11 in ec8543a

function ChangeCreator(uint256 _Id, address _NewCreator) external;

ID-10
Parameter WhiteListHelper.setupNewWhitelist(address)._whiteListAddress is not in mixedCase

Poolz-Helper/contracts/Fee/WhiteListHelper.sol

Line 23 in ec8543a

    
           function setupNewWhitelist(address _whiteListAddress) external firewallProtected onlyOwnerOrGov {

ID-11
Parameter ILockedDealV2.CreateNewPool(address,uint256,uint256,uint256,uint256,address)._FinishTime is not in mixedCase

Poolz-Helper/contracts/interfaces/ILockedDealV2.sol

Line 9 in ec8543a

uint256 _FinishTime, //Until what time the pool will end

ID-12
Parameter IWhiteList.LastRoundRegister(address,uint256)._Subject is not in mixedCase

Poolz-Helper/contracts/interfaces/IWhiteList.sol

Line 9 in ec8543a

function LastRoundRegister(address _Subject,uint256 _Id) external;

ID-13
Function ILockedDeal.CreateNewPool(address,uint64,uint256,address) is not in mixedCase

Poolz-Helper/contracts/interfaces/ILockedDeal.sol

Lines 5 to 10 in ec8543a

    
           function CreateNewPool( 
        
               address _Token, 
        
               uint64 _FinishTime, 
        
               uint256 _StartAmount, 
        
               address _Owner 
        
           ) external returns (uint256);

ID-14
Parameter IWhiteList.RemoveAddress(uint256,address[])._Id is not in mixedCase

Poolz-Helper/contracts/interfaces/IWhiteList.sol

Line 13 in ec8543a

function RemoveAddress(uint256 _Id, address[] calldata _Users) external;

ID-15
Function ERC20Token.FreeTest() is not in mixedCase

Poolz-Helper/contracts/token/ERC20Token.sol

Lines 22 to 24 in ec8543a

    
           function FreeTest() public { 
        
               _mint(msg.sender, 5_000_00 * 10 ** 18); 
        
           }

ID-16
Parameter ILockedDeal.CreateNewPool(address,uint64,uint256,address)._Owner is not in mixedCase

Poolz-Helper/contracts/interfaces/ILockedDeal.sol

Line 9 in ec8543a

address _Owner

ID-17
Function ILockedDealV2.Index() is not in mixedCase

Poolz-Helper/contracts/interfaces/ILockedDealV2.sol

Line 23 in ec8543a

function Index() external returns (uint256);

ID-18
Parameter IWhiteList.LastRoundRegister(address,uint256)._Id is not in mixedCase

Poolz-Helper/contracts/interfaces/IWhiteList.sol

Line 9 in ec8543a

function LastRoundRegister(address _Subject,uint256 _Id) external;

ID-19
Parameter Array.KeepNElementsInArray(uint256[],uint256)._n is not in mixedCase

Poolz-Helper/contracts/Array.sol

Line 11 in ec8543a

function KeepNElementsInArray(uint256[] memory _arr, uint256 _n)

ID-20
Parameter ILockedDealV2.CreateNewPool(address,uint256,uint256,uint256,uint256,address)._StartTime is not in mixedCase

Poolz-Helper/contracts/interfaces/ILockedDealV2.sol

Line 7 in ec8543a

uint256 _StartTime, //Until what time the pool will start

ID-21
Parameter Array.KeepNElementsInArray(address[],uint256)._arr is not in mixedCase

Poolz-Helper/contracts/Array.sol

Line 25 in ec8543a

function KeepNElementsInArray(address[] memory _arr, uint256 _n)

ID-22
Function ILockedDealV2.GetMyPoolsId(address) is not in mixedCase

Poolz-Helper/contracts/interfaces/ILockedDealV2.sol

Lines 25 to 27 in ec8543a

    
           function GetMyPoolsId( 
        
               address _UserAddress 
        
           ) external view returns (uint256[] memory);

ID-23
Parameter Array.addIfNotExsist(address[],address)._elem is not in mixedCase

Poolz-Helper/contracts/Array.sol

Line 81 in ec8543a

function addIfNotExsist(address[] storage _arr, address _elem) internal {

ID-24
Function ILockedDealV2.SplitPoolAmountFrom(uint256,uint256,address) is not in mixedCase

Poolz-Helper/contracts/interfaces/ILockedDealV2.sol

Lines 38 to 42 in ec8543a

    
           function SplitPoolAmountFrom( 
        
               uint256 _LDpoolId, 
        
               uint256 _Amount, 
        
               address _Address 
        
           ) external returns(uint256 poolId);

ID-25
Function IPOZBenefit.IsPOZHolder(address) is not in mixedCase

Poolz-Helper/contracts/interfaces/IPozBenefit.sol

Line 7 in ec8543a

function IsPOZHolder(address _Subject) external view returns (bool);

ID-26
Parameter ILockedDealV2.SplitPoolAmountFrom(uint256,uint256,address)._Address is not in mixedCase

Poolz-Helper/contracts/interfaces/ILockedDealV2.sol

Line 41 in ec8543a

address _Address

ID-27
Parameter ILockedDealV2.CreateNewPool(address,uint256,uint256,uint256,uint256,address)._CliffTime is not in mixedCase

Poolz-Helper/contracts/interfaces/ILockedDealV2.sol

Line 8 in ec8543a

uint256 _CliffTime, //Before CliffTime can't withdraw tokens

ID-28
Parameter Array.addIfNotExsist(address[],address)._arr is not in mixedCase

Poolz-Helper/contracts/Array.sol

Line 81 in ec8543a

function addIfNotExsist(address[] storage _arr, address _elem) internal {

ID-29
Function ILockedDealV2.Allowance(uint256,address) is not in mixedCase

Poolz-Helper/contracts/interfaces/ILockedDealV2.sol

Lines 44 to 47 in ec8543a

    
           function Allowance( 
        
               uint256 _poolId, 
        
               address _user 
        
           ) external view returns(uint256 amount);

ID-30
Parameter ILockedDealV2.CreateNewPool(address,uint256,uint256,uint256,uint256,address)._Token is not in mixedCase

Poolz-Helper/contracts/interfaces/ILockedDealV2.sol

Line 6 in ec8543a

address _Token, //token to lock address

ID-31
Parameter ILockedDealV2.WithdrawToken(uint256)._PoolId is not in mixedCase

Poolz-Helper/contracts/interfaces/ILockedDealV2.sol

Line 35 in ec8543a

uint256 _PoolId

ID-32
Function Array.KeepNElementsInArray(address[],uint256) is not in mixedCase

Poolz-Helper/contracts/Array.sol

Lines 25 to 37 in ec8543a

    
           function KeepNElementsInArray(address[] memory _arr, uint256 _n) 
        
               internal 
        
               pure 
        
               returns (address[] memory newArray) 
        
           { 
        
               if (_arr.length == _n) return _arr; 
        
               if (_arr.length <= _n) revert InvalidArrayLength(_arr.length, _n); 
        
               newArray = new address[](_n); 
        
               for (uint256 i = 0; i < _n; ++i) { 
        
                   newArray[i] = _arr[i]; 
        
               } 
        
               return newArray; 
        
           }

ID-33
Parameter FeeBaseHelper.setFee(address,uint256)._amount is not in mixedCase

Poolz-Helper/contracts/Fee/FeeBaseHelper.sol

Line 47 in ec8543a

    
           function setFee(address _token, uint _amount) external firewallProtected onlyOwnerOrGov {

ID-34
Parameter FeeBaseHelper.withdrawFee(address,address)._to is not in mixedCase

Poolz-Helper/contracts/Fee/FeeBaseHelper.sol

Line 52 in ec8543a

    
           function withdrawFee(address _token, address _to) external firewallProtected onlyOwnerOrGov {

ID-35
Parameter IWhiteList.ChangeCreator(uint256,address)._NewCreator is not in mixedCase

Poolz-Helper/contracts/interfaces/IWhiteList.sol

Line 11 in ec8543a

function ChangeCreator(uint256 _Id, address _NewCreator) external;

ID-36
Parameter IWhiteList.AddAddress(uint256,address[],uint256[])._Amount is not in mixedCase

Poolz-Helper/contracts/interfaces/IWhiteList.sol

Line 12 in ec8543a

    
           function AddAddress(uint256 _Id, address[] calldata _Users, uint256[] calldata _Amount) external;

ID-37
Parameter ILockedDeal.CreateNewPool(address,uint64,uint256,address)._StartAmount is not in mixedCase

Poolz-Helper/contracts/interfaces/ILockedDeal.sol

Line 8 in ec8543a

uint256 _StartAmount,

ID-38
Parameter ILockedDealV2.CreatePoolsWrtTime(address,uint256[],uint256[],uint256[],uint256[],address[])._StartAmount is not in mixedCase

Poolz-Helper/contracts/interfaces/ILockedDealV2.sol

Line 19 in ec8543a

uint256[] calldata _StartAmount,

ID-39
Function IWhiteList.RemoveAddress(uint256,address[]) is not in mixedCase

Poolz-Helper/contracts/interfaces/IWhiteList.sol

Line 13 in ec8543a

function RemoveAddress(uint256 _Id, address[] calldata _Users) external;

ID-40
Parameter IWhiteList.CreateManualWhiteList(uint256,address)._Contract is not in mixedCase

Poolz-Helper/contracts/interfaces/IWhiteList.sol

Line 10 in ec8543a

    
           function CreateManualWhiteList(uint256 _ChangeUntil, address _Contract) external payable returns(uint256 Id);

ID-41
Parameter ILockedDealV2.SplitPoolAmountFrom(uint256,uint256,address)._LDpoolId is not in mixedCase

Poolz-Helper/contracts/interfaces/ILockedDealV2.sol

Line 39 in ec8543a

uint256 _LDpoolId,

ID-42
Parameter ILockedDeal.CreateNewPool(address,uint64,uint256,address)._Token is not in mixedCase

Poolz-Helper/contracts/interfaces/ILockedDeal.sol

Line 6 in ec8543a

address _Token,

ID-43
Parameter ILockedDealV2.SplitPoolAmountFrom(uint256,uint256,address)._Amount is not in mixedCase

Poolz-Helper/contracts/interfaces/ILockedDealV2.sol

Line 40 in ec8543a

uint256 _Amount,

ID-44
Function ILockedDeal.WithdrawToken(uint256) is not in mixedCase

Poolz-Helper/contracts/interfaces/ILockedDeal.sol

Line 12 in ec8543a

function WithdrawToken(uint256 _PoolId) external returns (bool);

ID-45
Parameter IWhiteList.RemoveAddress(uint256,address[])._Users is not in mixedCase

Poolz-Helper/contracts/interfaces/IWhiteList.sol

Line 13 in ec8543a

function RemoveAddress(uint256 _Id, address[] calldata _Users) external;

ID-46
Parameter FeeBaseHelper.setFee(address,uint256)._token is not in mixedCase

Poolz-Helper/contracts/Fee/FeeBaseHelper.sol

Line 47 in ec8543a

    
           function setFee(address _token, uint _amount) external firewallProtected onlyOwnerOrGov {

ID-47
Function ILockedDealV2.GetMyPoolsIdByToken(address,address[]) is not in mixedCase

Poolz-Helper/contracts/interfaces/ILockedDealV2.sol

Lines 29 to 32 in ec8543a

    
           function GetMyPoolsIdByToken( 
        
               address _UserAddress, 
        
               address[] memory _Tokens 
        
           ) external view returns (uint256[] memory);

ID-48
Parameter IWhiteList.Register(address,uint256,uint256)._Subject is not in mixedCase

Poolz-Helper/contracts/interfaces/IWhiteList.sol

Line 8 in ec8543a

function Register(address _Subject,uint256 _Id,uint256 _Amount) external;

ID-49
Function IWhiteList.AddAddress(uint256,address[],uint256[]) is not in mixedCase

Poolz-Helper/contracts/interfaces/IWhiteList.sol

Line 12 in ec8543a

    
           function AddAddress(uint256 _Id, address[] calldata _Users, uint256[] calldata _Amount) external;

ID-50
Parameter IWhiteList.Check(address,uint256)._Subject is not in mixedCase

Poolz-Helper/contracts/interfaces/IWhiteList.sol

Line 7 in ec8543a

function Check(address _Subject, uint256 _Id) external view returns(uint);

ID-51
Parameter IWhiteList.AddAddress(uint256,address[],uint256[])._Id is not in mixedCase

Poolz-Helper/contracts/interfaces/IWhiteList.sol

Line 12 in ec8543a

    
           function AddAddress(uint256 _Id, address[] calldata _Users, uint256[] calldata _Amount) external;

ID-52
Parameter ILockedDealV2.AllPoolz(uint256)._LDpoolId is not in mixedCase

Poolz-Helper/contracts/interfaces/ILockedDealV2.sol

Line 49 in ec8543a

function AllPoolz(uint256 _LDpoolId) external view returns (

ID-53
Parameter ILockedDealV2.CreateNewPool(address,uint256,uint256,uint256,uint256,address)._StartAmount is not in mixedCase

Poolz-Helper/contracts/interfaces/ILockedDealV2.sol

Line 10 in ec8543a

uint256 _StartAmount, //Total amount of the tokens to sell in the pool

ID-54
Function Array.KeepNElementsInArray(uint256[],uint256) is not in mixedCase

Poolz-Helper/contracts/Array.sol

Lines 11 to 23 in ec8543a

    
           function KeepNElementsInArray(uint256[] memory _arr, uint256 _n) 
        
               internal 
        
               pure 
        
               returns (uint256[] memory newArray) 
        
           { 
        
               if (_arr.length == _n) return _arr; 
        
               if (_arr.length <= _n) revert InvalidArrayLength(_arr.length, _n); 
        
               newArray = new uint256[](_n); 
        
               for (uint256 i = 0; i < _n; ++i) { 
        
                   newArray[i] = _arr[i]; 
        
               } 
        
               return newArray; 
        
           }

ID-55
Parameter PozBenefit.setPozTimer(uint256)._pozTimer is not in mixedCase

Poolz-Helper/contracts/PozBenefit.sol

Line 31 in ec8543a

    
           function setPozTimer(uint256 _pozTimer) public onlyOwnerOrGov percentCheckOk(_pozTimer) {

ID-56
Parameter ILockedDealV2.GetMyPoolsIdByToken(address,address[])._UserAddress is not in mixedCase

Poolz-Helper/contracts/interfaces/ILockedDealV2.sol

Line 30 in ec8543a

address _UserAddress,

ID-57
Parameter ILockedDeal.CreateNewPool(address,uint64,uint256,address)._FinishTime is not in mixedCase

Poolz-Helper/contracts/interfaces/ILockedDeal.sol

Line 7 in ec8543a

uint64 _FinishTime,

ID-58
Function IWhiteList.CreateManualWhiteList(uint256,address) is not in mixedCase

Poolz-Helper/contracts/interfaces/IWhiteList.sol

Line 10 in ec8543a

    
           function CreateManualWhiteList(uint256 _ChangeUntil, address _Contract) external payable returns(uint256 Id);

ID-59
Parameter ILockedDealV2.CreatePoolsWrtTime(address,uint256[],uint256[],uint256[],uint256[],address[])._Owner is not in mixedCase

Poolz-Helper/contracts/interfaces/ILockedDealV2.sol

Line 20 in ec8543a

address[] calldata _Owner

ID-60
Function IWhiteList.Register(address,uint256,uint256) is not in mixedCase

Poolz-Helper/contracts/interfaces/IWhiteList.sol

Line 8 in ec8543a

function Register(address _Subject,uint256 _Id,uint256 _Amount) external;

ID-61
Parameter ILockedDealV2.CreatePoolsWrtTime(address,uint256[],uint256[],uint256[],uint256[],address[])._CliffTime is not in mixedCase

Poolz-Helper/contracts/interfaces/ILockedDealV2.sol

Line 17 in ec8543a

uint256[] calldata _CliffTime,

ID-62
Parameter ILockedDealV2.GetMyPoolsIdByToken(address,address[])._Tokens is not in mixedCase

Poolz-Helper/contracts/interfaces/ILockedDealV2.sol

Line 31 in ec8543a

address[] memory _Tokens

ID-63
Parameter IWhiteList.Register(address,uint256,uint256)._Id is not in mixedCase

Poolz-Helper/contracts/interfaces/IWhiteList.sol

Line 8 in ec8543a

function Register(address _Subject,uint256 _Id,uint256 _Amount) external;

ID-64
Function ILockedDealV2.AllPoolz(uint256) is not in mixedCase

Poolz-Helper/contracts/interfaces/ILockedDealV2.sol

Lines 49 to 57 in ec8543a

    
           function AllPoolz(uint256 _LDpoolId) external view returns ( 
        
               uint256 StartTime, 
        
               uint256 CliffTime, 
        
               uint256 FinishTime, 
        
               uint256 StartAmount, 
        
               uint256 DebitedAmount, 
        
               address Owner, 
        
               address Token 
        
           );

ID-65
Parameter Array.KeepNElementsInArray(address[],uint256)._n is not in mixedCase

Poolz-Helper/contracts/Array.sol

Line 25 in ec8543a

function KeepNElementsInArray(address[] memory _arr, uint256 _n)

ID-66
Parameter Array.isInArray(address[],address)._elem is not in mixedCase

Poolz-Helper/contracts/Array.sol

Line 70 in ec8543a

function isInArray(address[] memory _arr, address _elem)

ID-67
Function ILockedDealV2.WithdrawToken(uint256) is not in mixedCase

Poolz-Helper/contracts/interfaces/ILockedDealV2.sol

Lines 34 to 36 in ec8543a

    
           function WithdrawToken( 
        
               uint256 _PoolId 
        
           ) external returns (uint256 withdrawnAmount);

ID-68
Parameter Array.KeepNElementsInArray(uint256[],uint256)._arr is not in mixedCase

Poolz-Helper/contracts/Array.sol

Line 11 in ec8543a

function KeepNElementsInArray(uint256[] memory _arr, uint256 _n)

ID-69
Parameter IWhiteList.AddAddress(uint256,address[],uint256[])._Users is not in mixedCase

Poolz-Helper/contracts/interfaces/IWhiteList.sol

Line 12 in ec8543a

    
           function AddAddress(uint256 _Id, address[] calldata _Users, uint256[] calldata _Amount) external;

ID-70
Parameter FeeBaseHelper.withdrawFee(address,address)._token is not in mixedCase

Poolz-Helper/contracts/Fee/FeeBaseHelper.sol

Line 52 in ec8543a

    
           function withdrawFee(address _token, address _to) external firewallProtected onlyOwnerOrGov {

ID-71
Parameter Array.getArraySum(uint256[])._array is not in mixedCase

Poolz-Helper/contracts/Array.sol

Line 57 in ec8543a

function getArraySum(uint256[] memory _array)

ID-72
Parameter ETHHelper.transferETH(address,uint256)._amount is not in mixedCase

Poolz-Helper/contracts/ETHHelper.sol

Line 37 in ec8543a

    
           function transferETH(address payable receiver, uint256 _amount) internal firewallProtectedSig(0xfd69c215) {

ID-73
Parameter IWhiteList.ChangeCreator(uint256,address)._Id is not in mixedCase

Poolz-Helper/contracts/interfaces/IWhiteList.sol

Line 11 in ec8543a

function ChangeCreator(uint256 _Id, address _NewCreator) external;

ID-74
Parameter ILockedDealV2.CreatePoolsWrtTime(address,uint256[],uint256[],uint256[],uint256[],address[])._StartTime is not in mixedCase

Poolz-Helper/contracts/interfaces/ILockedDealV2.sol

Line 16 in ec8543a

uint256[] calldata _StartTime,

ID-75
Function IWhiteList.Check(address,uint256) is not in mixedCase

Poolz-Helper/contracts/interfaces/IWhiteList.sol

Line 7 in ec8543a

function Check(address _Subject, uint256 _Id) external view returns(uint);

ID-76
Function IWhiteList.LastRoundRegister(address,uint256) is not in mixedCase

Poolz-Helper/contracts/interfaces/IWhiteList.sol

Line 9 in ec8543a

function LastRoundRegister(address _Subject,uint256 _Id) external;

ID-77
Parameter IWhiteList.Register(address,uint256,uint256)._Amount is not in mixedCase

Poolz-Helper/contracts/interfaces/IWhiteList.sol

Line 8 in ec8543a

function Register(address _Subject,uint256 _Id,uint256 _Amount) external;

ID-78
Parameter Array.isArrayOrdered(uint256[])._arr is not in mixedCase

Poolz-Helper/contracts/Array.sol

Line 40 in ec8543a

function isArrayOrdered(uint256[] memory _arr)

ID-79
Parameter ILockedDealV2.CreatePoolsWrtTime(address,uint256[],uint256[],uint256[],uint256[],address[])._Token is not in mixedCase

Poolz-Helper/contracts/interfaces/ILockedDealV2.sol

Line 15 in ec8543a

address _Token,

ID-80
Parameter ILockedDealV2.CreateNewPool(address,uint256,uint256,uint256,uint256,address)._Owner is not in mixedCase

Poolz-Helper/contracts/interfaces/ILockedDealV2.sol

Line 11 in ec8543a

address _Owner // Who the tokens belong to

ID-81
Parameter IWhiteList.Check(address,uint256)._Id is not in mixedCase

Poolz-Helper/contracts/interfaces/IWhiteList.sol

Line 7 in ec8543a

function Check(address _Subject, uint256 _Id) external view returns(uint);

ID-82
Function ILockedDealV2.CreateNewPool(address,uint256,uint256,uint256,uint256,address) is not in mixedCase

Poolz-Helper/contracts/interfaces/ILockedDealV2.sol

Lines 5 to 12 in ec8543a

    
           function CreateNewPool( 
        
               address _Token, //token to lock address 
        
               uint256 _StartTime, //Until what time the pool will start 
        
               uint256 _CliffTime, //Before CliffTime can't withdraw tokens 
        
               uint256 _FinishTime, //Until what time the pool will end 
        
               uint256 _StartAmount, //Total amount of the tokens to sell in the pool 
        
               address _Owner // Who the tokens belong to 
        
           ) external payable;

ID-83
Parameter ILockedDeal.WithdrawToken(uint256)._PoolId is not in mixedCase

Poolz-Helper/contracts/interfaces/ILockedDeal.sol

Line 12 in ec8543a

function WithdrawToken(uint256 _PoolId) external returns (bool);

ID-84
Parameter Array.isInArray(address[],address)._arr is not in mixedCase

Poolz-Helper/contracts/Array.sol

Line 70 in ec8543a

function isInArray(address[] memory _arr, address _elem)

ID-85
Parameter IPOZBenefit.IsPOZHolder(address)._Subject is not in mixedCase

Poolz-Helper/contracts/interfaces/IPozBenefit.sol

Line 7 in ec8543a

function IsPOZHolder(address _Subject) external view returns (bool);

ID-86
Parameter IWhiteList.CreateManualWhiteList(uint256,address)._ChangeUntil is not in mixedCase

Poolz-Helper/contracts/interfaces/IWhiteList.sol

Line 10 in ec8543a

    
           function CreateManualWhiteList(uint256 _ChangeUntil, address _Contract) external payable returns(uint256 Id);

ID-87
Function ILockedDealV2.CreatePoolsWrtTime(address,uint256[],uint256[],uint256[],uint256[],address[]) is not in mixedCase

Poolz-Helper/contracts/interfaces/ILockedDealV2.sol

Lines 14 to 21 in ec8543a

    
           function CreatePoolsWrtTime( 
        
               address _Token, 
        
               uint256[] calldata _StartTime, 
        
               uint256[] calldata _CliffTime, 
        
               uint256[] calldata _FinishTime, 
        
               uint256[] calldata _StartAmount, 
        
               address[] calldata _Owner 
        
           ) external payable;

extend ILockDealNFT interface

f2271be

YouStillAlive merged commit 1903d23 into master Jan 30, 2025
9 checks passed

YouStillAlive deleted the issue-113 branch January 30, 2025 10:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

extend `ILockDealNFT` interface #114

extend `ILockDealNFT` interface #114

Uh oh!

YouStillAlive commented Jan 30, 2025

Uh oh!

sonarqubecloud bot commented Jan 30, 2025

Uh oh!

github-actions bot commented Jan 30, 2025

Uh oh!

codecov bot commented Jan 30, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jan 30, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

extend ILockDealNFT interface #114

extend ILockDealNFT interface #114

Uh oh!

Conversation

YouStillAlive commented Jan 30, 2025

Uh oh!

sonarqubecloud bot commented Jan 30, 2025

Quality Gate passed

Uh oh!

github-actions bot commented Jan 30, 2025

Methods

Deployments

Solidity and Network Config

Uh oh!

codecov bot commented Jan 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Jan 30, 2025

Slither report

events-access

missing-zero-check

low-level-calls

naming-convention

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

extend `ILockDealNFT` interface #114

extend `ILockDealNFT` interface #114

codecov bot commented Jan 30, 2025 •

edited

Loading