Retries for HTTP calls via Polly lib #352
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR integrates the Polly library to add retry logic for HTTP calls and blockchain operations across the application. The retry mechanism is implemented via the IRetryExecutor interface from the Poolz.Finance.CSharp.Polly.Extensions package.
- Added retry wrapper to GraphQL queries in Strapi client
- Added retry wrapper to ERC20 token cache operations
- Added retry wrapper to NFT supply range checks and pool info fetching
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/MetaDataAPI/MetaDataAPI.csproj | Adds the Polly extensions package dependency |
| src/MetaDataAPI/DefaultServiceProvider.cs | Registers IRetryExecutor as a singleton service |
| src/MetaDataAPI/Services/Strapi/StrapiClient.cs | Wraps GraphQL queries with retry logic using ExecuteAsync |
| src/MetaDataAPI/Services/Erc20/Erc20Provider.cs | Wraps cache operations with retry logic using Execute |
| src/MetaDataAPI/Routing/Requests/GetMetadataRequestHandler.cs | Wraps blockchain calls with retry logic and fixes error response parameter (bug introduced) |
| src/MetaDataAPI/Services/Http/FailureOnlyLoggingHandler.cs | Renames constructor parameter from inner to innerHandler for clarity |
| tests/MetaDataAPI.Tests/Services/Erc20/Erc20ProviderTests.cs | Updates test to mock the new IRetryExecutor dependency |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
DiagramsDiagrams summary
|
SummarySummary
CoverageMetaDataAPI - 31.5%
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Lomet
approved these changes
Nov 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.