Skip to content

Fix verify sign #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
petrovMA wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix verify sign #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2323d1d
fix `verify()` function for digital signature
Jan 5, 2020
22dade6
add tests for `verify()` and `sign()` functions
Jan 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,8 +351,10 @@ crypto = {
sbytes: sbytes,
}
},
verify: function (bytes, sig, pk) {
return library.sodium.crypto_sign_verify_detached(sig, utility.hex2buf(bytes), utility.b58cdecode(pk, prefix.edpk));
verify: function (bytes, sig, pk, wm) {
var bb = utility.hex2buf(bytes);
if (typeof wm != 'undefined') bb = utility.mergebuf(wm, bb);
return library.sodium.crypto_sign_verify_detached(sig, library.sodium.crypto_generichash(32, bb), utility.b58cdecode(pk, prefix.edpk));
},
};
node = {
Expand Down
15 changes: 15 additions & 0 deletions test/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ describe('main', () => {
describe('crypto', () => {
const main = require('../src/main');
const crypto = main.eztz.crypto;
const watermark = main.eztz.watermark;

test('generateMnemonic', () => {
const string = crypto.generateMnemonic();
Expand Down Expand Up @@ -124,6 +125,20 @@ describe('main', () => {
// expect(typeof keys.edsig).toBe('string');
// expect(typeof keys.sbytes).toBe('string');
});

test('sign and verify', () => {
const keys = crypto.generateKeys('', '');
const bytes = "20aa4d05fecad06b193f909564d4fcfd90e4cd01a6e13298329d802420dff96a9be42bcbe4739a783c117fa13fb42cf007cb67054a12fb977aca95c442745805";
let sign = crypto.sign(bytes, keys.sk);
expect(crypto.verify(bytes, sign.sig, keys.pk)).toBe(true);
});

test('sign and verify with watermark', () => {
const keys = crypto.generateKeys('', '');
const bytes = "20aa4d05fecad06b193f909564d4fcfd90e4cd01a6e13298329d802420dff96a9be42bcbe4739a783c117fa13fb42cf007cb67054a12fb977aca95c442745805";
let sign = crypto.sign(bytes, keys.sk, watermark.generic);
expect(crypto.verify(bytes, sign.sig, keys.pk, watermark.generic)).toBe(true);
});
});

describe('node', () => {
Expand Down