Edge fixes #46
Open
Edge fixes #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stephenandrews Can you review ? |
swansontec
force-pushed
the
edge-fixes
branch
from
efb265a to
eefa603
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the fixes Edge Wallet needs to get eztz working smoothly in our app.
The first is to move
codecovfrom thedependenciestodevDependencies, since you are using an older version that has security vulnerabilities, and we prefer not to have warnings when peopleyarn installour libraries.The second is to upgrade to bip39 v3. This is the current version, and most of the other coins are already using it. Requiring an older version means we end up with two copies of in our app, which is expensive (bip39 is a big library).
I have tried to minimize the diffs this time around. If you like, I can submit another PR that applies prettier / ESLint to the codebase for automatic formatting & checking for common errors.