Skip to content

loosen xcodeproj dependency #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xinsight wants to merge 6 commits into
base: master
Choose a base branch
from
Open

loosen xcodeproj dependency #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
77e8e03
loosen xcodeproj dependency
Jun 12, 2014
274980b
replace deprecated should with expect
Jun 12, 2014
c417212
add missing bracket
Jun 13, 2014
e7443b8
Fix for I should see step definition
Jul 7, 2014
da1aa43
updated other expect()
Jul 7, 2014
60b87ef
Merge pull request #1 from nhamming/master
xinsight Jul 7, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion gem/frank-cucumber.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ Gem::Specification.new do |s|
s.add_dependency( "json", ["1.8.1"] ) # TODO: figure out how to be more permissive as to which JSON gems we allow
s.add_dependency( "dnssd", ["~>2.0"] )
s.add_dependency( "thor", ["~>0.18.1"] )
s.add_dependency( "xcodeproj", ["~>0.14.1"] )
s.add_dependency( "xcodeproj", ["~>0.14"] )

s.add_development_dependency( "rr" )
s.add_development_dependency( "yard" )
Expand Down
6 changes: 3 additions & 3 deletions gem/lib/frank-cucumber/frank_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,19 +127,19 @@ def element_exists( selector )
# @raise an rspec exception if the assertion fails
# @see #element_exists, #check_element_does_not_exist
def check_element_exists( selector )
element_exists( selector ).should be_true, "Could not find element matching selector (#{selector})"
expect(element_exists(selector)).to be_true, "Could not find element matching selector (#{selector})"
end

def check_element_exists_and_is_visible( selector )
element_is_not_hidden( selector ).should be_true, "Could not find visible element matching selector (#{selector})"
expect(element_is_not_hidden(selector)).to be_true, "Could not find visible element matching selector (#{selector})"
end

# Assert whether there are no views in the current view heirarchy which match the specified selector.
# @param [String] selector a view selector.
# @raise an rspec exception if the assertion fails
# @see #element_exists, #check_element_exists
def check_element_does_not_exist( selector )
element_exists( selector ).should be_false, "Found element matching selector when it should not exist (#{selector})"
expect(element_exists(selector)).to be_true, "Found element matching selector when it should not exist (#{selector})"
end

def check_element_does_not_exist_or_is_not_visible( selector )
Expand Down