Skip to content

Make client_cookie a persistent and editable client attribute #563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
byewokko merged 5 commits into from
Mar 19, 2026
Merged

Make client_cookie a persistent and editable client attribute #563

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9c02d48
make client_cookie a persistent client attr
byewokko Mar 18, 2026
392cba9
update changelog
byewokko Mar 18, 2026
6e3dcf5
Merge branch 'main' into feature/persistent-cooki-name
byewokko Mar 18, 2026
0410c87
safer regex
byewokko Mar 19, 2026
07bf615
update changelog
byewokko Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
## v25.48

### Pre-releases
- v25.48-alpha22
- v25.48-alpha21
- v25.48-alpha20
- v25.48-alpha19
Expand Down Expand Up @@ -37,6 +38,7 @@
- Fix the query in login redirection response (#547, v25.48-alpha5)

### Features
- Make `client_cookie` a persistent and editable client attribute (#563, v25.48-alpha22)
- Paginable endpoint for listing tenant's assigned credential IDs (#562, v25.48-alpha19)
- Document external login configuration (#557, v25.48-alpha18)
- Add optional `managed_by` field to Tenant object (#556, v25.48-alpha16)
Expand Down
6 changes: 6 additions & 0 deletions seacatauth/client/schema.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,12 @@
"description":
"Domain of the client cookie. Defaults to the application's global cookie domain."
},
"cookie_name": { # NON-CANONICAL
"type": "string",
"pattern": "^[a-zA-Z0-9\\._]{0,64}$",
"description":
"Name of the client cookie. Defaults to the application's global cookie name plus a string generated from client ID."
},
Comment thread
coderabbitai[bot] marked this conversation as resolved.
"cookie_webhook_uri": { # NON-CANONICAL
"type": "string",
"description":
Expand Down
4 changes: 4 additions & 0 deletions seacatauth/client/service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -808,6 +808,10 @@ def _set_credentials_id(app, client: dict) -> dict:


def _set_cookie_name(app, client: dict) -> dict:
if client.get("cookie_name") not in (None, ""):
# Cookie name is already set, do not override
return client

cookie_svc = app.get_service("seacatauth.CookieService")
if not cookie_svc:
return client
Expand Down
Loading