Skip to content

Library: guard against empty providers to prevent IndexError #735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mithunbharadwaj wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Library: guard against empty providers to prevent IndexError #735

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions asab/library/service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -407,6 +407,10 @@ async def _read_favorites(self):
- system
"""
fav_data = None
if len(self.Libraries) == 0:
self.Favorites = {}
self.FavoritePaths = []
return

try:
fav_file = await self.Libraries[0].read('/.favorites.yaml')
Expand Down Expand Up @@ -484,8 +488,14 @@ async def _read_favorites(self):

async def _read_disabled(self, publish_changes=False):

if len(self.Libraries) == 0:
self.Disabled = {}
self.DisabledPaths = []
return

old_disabled = self.Disabled.copy()
old_disabled_paths = list(self.DisabledPaths)

# Read the file
disabled_file = await self.Libraries[0].read('/.disabled.yaml')

Expand Down