Open
Conversation
ateska
requested changes
Jun 18, 2025
asab/library/service.py
Outdated
| tarobj.addfile(tarinfo=info, fileobj=my_data) | ||
| tarobj.addfile(tarinfo=info, fileobj=data) | ||
|
|
||
| # -- Tenant layers -- |
Contributor
There was a problem hiding this comment.
Tenant and global layers will be mixed, so re-import will destroy the correct content of the library.
This is not a correct design.
Collaborator
Author
There was a problem hiding this comment.
@ateska All the tenant contents will be copied to /tenants/ is that wrong to create the separation between tenant and global?
If so what is the correct approach?
Contributor
There was a problem hiding this comment.
Yes - but the export is done for a specific tenant - so only 1 tenant instance will be present in /tenants/
ateska
requested changes
Jun 22, 2025
asab/library/service.py
Outdated
| tarobj.addfile(tarinfo=info, fileobj=my_data) | ||
| tarobj.addfile(tarinfo=info, fileobj=data) | ||
|
|
||
| # -- Tenant layers -- |
Contributor
There was a problem hiding this comment.
Yes - but the export is done for a specific tenant - so only 1 tenant instance will be present in /tenants/
added 2 commits
June 30, 2025 08:46
Contributor
|
This looks ok - can you please demonstrate on review a process of export & import? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.