Library: GitProvider - Don't stop the app even if the library is not ready#639
Library: GitProvider - Don't stop the app even if the library is not ready#639
Conversation
| else: | ||
| L.exception("Git repository not initialized: {}".format(err)) | ||
| self.App.stop() | ||
| L.critical("Git repository not initialized: {}".format(err)) |
There was a problem hiding this comment.
"critical" error means that the app will exit ... otherwise this is an error (at all instances)
There was a problem hiding this comment.
in that case I only remove lines that stop the app
|
return before set ready - the library should not be ready if the gitprovider fails. |
| ) | ||
| else: | ||
| L.exception("Git repository not initialized: {}".format(err)) | ||
| self.App.stop() |
There was a problem hiding this comment.
return ... don't claim "library ready" - as discussed.
There was a problem hiding this comment.
I added returns. But I tested it in the remote control. And remote control works even if the library is not ready. asab.library module does not restrict you to read from the library when library is not ready. So it is up to each microservice to check whether the library is ready before reading. Moreover, in remote control, I subscribe to changes in the Library on library ready. But the Library.ready! signal never comes. So, the remote control is running with wrong set of library layers and without the update of model. Which is serious.
I think we need to decide whether this should be solved on the asab level or on the microservice level and adjust first. Only then, this can be merged.
async def _on_library_ready(self, event_name, library=None):
# subscribe to /Site - that's wehere the model files are
await self.App.LibraryService.subscribe(self.MODEL_PATH)
self.App.TaskService.schedule(self.update_model_cache())
There was a problem hiding this comment.
Library should not be usable if not ready.
|
Sorry, I probably forgot about this MR. |
3 participants
I don't want the whole app to crash even when the git repo is not initialized.
With my edits and failure of the repo initialization, the Library won't get ready. The functionality of the application will be significantly impaired. It probably won't be repairable from the UI as even remote control needs Library to change things. However, we can at least keep the apps up and provide info to the UI about what is wrong. When all containers keep restarting because of typo in the library config, it is scary.