Skip to content

Refactor zookeeper error handling #595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eliska-n wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Refactor zookeeper error handling #595

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions asab/library/providers/zookeeper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,11 +235,12 @@ async def read(self, path: str) -> typing.IO:

try:
node_data = await self.Zookeeper.get_data(node_path)
# NoNodeError is silent from the wrapper (returns None)
except kazoo.exceptions.ConnectionClosedError:
L.warning("Zookeeper library provider is not ready")
raise RuntimeError("Zookeeper library provider is not ready")
except kazoo.exceptions.NoNodeError:
return None
except kazoo.exceptions.KazooException:
return None # TODO: should it be silent or propagated?

# Consider adding other exceptions from Kazoo to indicate common non-critical errors

Expand Down