Adding array notation for proper minification #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I see that there is min version in dist folder, but It could be nice to add modifications of this PR in the non min file |
Author
|
Thanks for the notice. We have 1.1.6 installed here and there was no minified version in the install. |
Owner
|
I'm sorry guys, I made a bunch of code changes right after this pull request and I accidentally left this out. I will add it back. Sorry about that! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into an issue where we installed angular-wysiwyg using bower, but our grunt compile task (taken from Josh Miller's ngbp) was not minifying this file, meaning that the uglify was breaking our app. We didn't want to run ng-Annotate on all of our vendor files because that takes a lot of time when it's not normally needed, so I figured adding the array notation to this project would be the simplest solution and hopefully save others the same headache.