Modal QR Code without permanent one and fixed hiddenId#26
Open
Yannis4444 wants to merge 2 commits intoTeraTech:masterfrom
Open
Modal QR Code without permanent one and fixed hiddenId#26Yannis4444 wants to merge 2 commits intoTeraTech:masterfrom
Yannis4444 wants to merge 2 commits intoTeraTech:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I made it possible to show the QR Code as a modal only without having it shown all the time. This was not possible before as data from the permanent QR Code was needed in the modal.
I also fixed the handling of the hiddenId parameter. It made the created QR Code unusable.