Add token usage tracker #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lingtonglu
commented
Aug 3, 2025
lingtonglu
commented
- add a token usage tracker service for all the endpoints
- update the providers to extract the cached & reasoning tokens
- implement the tombstone forge key / provider key deletion
- code refactoring
* add a token usage tracker service for all the endpoints * update the providers to extract the cached & reasoning tokens * implement the tombstone forge key / provider key deletion * code refactoring
wilsonccccc
reviewed
Aug 4, 2025
| def upgrade() -> None: | ||
| op.add_column('provider_keys', sa.Column('deleted_at', sa.DateTime(timezone=True), nullable=True)) | ||
| op.add_column('forge_api_keys', sa.Column('deleted_at', sa.DateTime(timezone=True), nullable=True)) | ||
| op.alter_column('forge_api_keys', 'key', nullable=True) |
Contributor
There was a problem hiding this comment.
why does "key" can be nullable?
Contributor
Author
There was a problem hiding this comment.
When the user is trying to deleted this record. I would like to wipe out the key value to be None so there is no security issue. We only keep the id/name and the created/deleted timestamp for reference check.
Contributor
Author
There was a problem hiding this comment.
The same goes for provider keys, I would wipe out the encrypted_api_key value there. Probably base_url as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.