Refactor database interactions to use AsyncSession and switch to async cache #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilsonccccc
reviewed
Jul 19, 2025
wilsonccccc
reviewed
Jul 19, 2025
wilsonccccc
reviewed
Jul 19, 2025
wilsonccccc
reviewed
Jul 19, 2025
wilsonccccc
reviewed
Jul 19, 2025
wilsonccccc
reviewed
Jul 19, 2025
wilsonccccc
reviewed
Jul 19, 2025
wilsonccccc
reviewed
Jul 19, 2025
wilsonccccc
reviewed
Jul 19, 2025
| input_tokens=input_tokens, | ||
| output_tokens=output_tokens, | ||
| ) | ||
| finally: |
Contributor
There was a problem hiding this comment.
don't we need finally?
Contributor
Author
There was a problem hiding this comment.
Oh I missed that. Let me create a asynccontextmanager function to handle the close. And we could reuse it.
Contributor
|
Overall LGTM, once check the last few comments, I think it is good to go |
Dokujaa
reviewed
Jul 19, 2025
wilsonccccc
approved these changes
Jul 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.