Added joins to password protected channels#75
Open
akainocode wants to merge 2 commits intoTennu:masterfrom
Open
Added joins to password protected channels#75akainocode wants to merge 2 commits intoTennu:masterfrom
akainocode wants to merge 2 commits intoTennu:masterfrom
Conversation
src/plugin/action/join.sjs
Outdated
| if(typeof(channel) === 'object'){ | ||
| var info = channel; | ||
| rawf('JOIN %s :%s', info.channel, info.password); | ||
| } |
Member
There was a problem hiding this comment.
Style: No newline after the closing brace for an if.
akainocode
force-pushed
the
patch-1
branch
2 times, most recently
from
e1b6b94 to
9cca8e9
Compare
In the config.json, instead of "#channel" one can use {"channel":"#channel", "password":"password"}
Member
|
This needs tests. |
Contributor
|
@akainocode Can you add a few tests for this please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the ability to join a password protected channel. In the config.json, instead of "#channel" one can use {"channel":"#channel", "password":"password"}