Skip to content

fix: handle unrecognized language codes gracefully #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gwuen wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: handle unrecognized language codes gracefully #236

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions frog/language_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,14 +232,18 @@ def get_downloaded_codes(self, force: bool = False) -> List[str]:
for lang_file in os.listdir(tessdata_dir)]
self._need_update_cache = False
logger.debug(f"Cache downloaded codes: {self._downloaded_codes}")
return sorted(self._downloaded_codes, key=lambda x: self.get_language(x))

recognized_codes = []
for code in self._downloaded_codes:
if code not in self._languages:
logger.warning(f'Unrecognized language code: {code}')
continue
recognized_codes.append(code)

return sorted(recognized_codes, key=lambda x: self.get_language(x))

def get_downloaded_languages(self, force: bool = False) -> List[str]:
languages = []
for code in self.get_downloaded_codes(force):
if code in self._languages:
languages.append(self.get_language(code))
return sorted(languages)
return sorted({self.get_language(code) for code in self.get_downloaded_codes(force)})

def download(self, code):
self.emit('added', code)
Expand Down