fix: 🐛 jsx syntax used in js file #152
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lczzlczz
commented
Sep 14, 2022
Comment on lines
+42
to
+48
| return createElement("div", { | ||
| style: { | ||
| width, | ||
| height, | ||
| }, | ||
| ref, | ||
| }); |
Contributor
Author
There was a problem hiding this comment.
use createElement function to create <div> element.
lczzlczz
commented
Sep 14, 2022
Comment on lines
+53
to
+76
| height: PropTypes.string, | ||
| width: PropTypes.string, | ||
| name: PropTypes.string, | ||
| loading: PropTypes.element, | ||
| url: PropTypes.string, | ||
| alive: PropTypes.bool, | ||
| fetch: PropTypes.func, | ||
| props: PropTypes.object, | ||
| attrs: PropTypes.object, | ||
| replace: PropTypes.func, | ||
| sync: PropTypes.bool, | ||
| prefix: PropTypes.object, | ||
| fiber: PropTypes.bool, | ||
| degrade: PropTypes.bool, | ||
| plugins: PropTypes.array, | ||
| beforeLoad: PropTypes.func, | ||
| beforeMount: PropTypes.func, | ||
| afterMount: PropTypes.func, | ||
| beforeUnmount: PropTypes.func, | ||
| afterUnmount: PropTypes.func, | ||
| activated: PropTypes.func, | ||
| deactivated: PropTypes.func, | ||
| loadError: PropTypes.func, | ||
| }; |
Contributor
Author
There was a problem hiding this comment.
change indentation from 4 spaces to 2 spaces.
lczzlczz
commented
Sep 14, 2022
Comment on lines
-62
to
-76
| import React from "react"; | ||
| import React, { createElement } from "react"; | ||
| import PropTypes from "prop-types"; | ||
| import { bus, setupApp ,preloadApp, startApp, destroyApp } from "wujie"; | ||
| import { bus, preloadApp, startApp, destroyApp, setupApp } from "wujie"; | ||
|
|
||
| export default class WujieReact extends React.PureComponent { | ||
| static propTypes = { | ||
| height: PropTypes.string, | ||
| width: PropTypes.string, | ||
| name: PropTypes.string, | ||
| loading: PropTypes.element; | ||
| url: PropTypes.string, | ||
| alive: PropTypes.bool, | ||
| fetch: PropTypes.func, | ||
| props: PropTypes.object, | ||
| replace: PropTypes.func, |
Contributor
Author
There was a problem hiding this comment.
align to packages/wujie-react/index.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm run test通过详细描述
JSX syntax is used in a js file, change it from sugar to function calls.
From:
To: