Fix: config rewrite unable to update some RocksDB options #444
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wsa-wsa
force-pushed
the
rewrite
branch
9 times, most recently
from
448d119 to
4e5a481
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix the bug of config rewrite #443
Motivation and Context
This PR fixes a bug where the CONFIG REWRITE command fails to persist changes made via CONFIG SET for certain configuration parameters to the configuration file. Specifically, after successfully setting a new value (e.g., rocks.min_blob_size), executing CONFIG REWRITE reports success (OK), but the actual configuration file remains unchanged. This behavior undermines the purpose of CONFIG REWRITE, which is to ensure runtime configuration changes are durable across server restarts.
Types of Changes
Checklist: