Conversation
These aren’t being used, and as we always generate OpenAPI specs, there isn’t really any need for them until we also generate code from the OpenAPI specs. At the moment they’re just a way of specifying a language name, which may be useful one day, so I’ll leave a PR in for their readdition.
Codecov Report
@@ Coverage Diff @@
## develop #399 +/- ##
===========================================
+ Coverage 98.93% 98.95% +0.02%
===========================================
Files 137 137
Lines 3179 3167 -12
Branches 44 51 +7
===========================================
- Hits 3145 3134 -11
+ Misses 34 33 -1
Continue to review full report at Codecov.
|
jaylees14
approved these changes
Apr 28, 2020
Lewiky
approved these changes
Apr 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These aren’t being used, and as we always generate OpenAPI specs, there isn’t really any need for them until we also generate code from the OpenAPI specs. At the moment they’re just a way of specifying a language name, which may be useful one day, so I’ll leave a PR in for their readdition (#400).