Skip to content

[DSL] Add support for a nullable annotation in SQL#333

Draft
c-harding wants to merge 3 commits intodevelopfrom
possible-feature/add-nullable
Draft

[DSL] Add support for a nullable annotation in SQL#333
c-harding wants to merge 3 commits intodevelopfrom
possible-feature/add-nullable

Conversation

@c-harding
Copy link
Copy Markdown
Contributor

Still need to add support in Go, which will involve treating a lot of stuff as pointers, and checking that the postgres bindings support that (how else can you set stuff to null/non-null dynamically?).

This reverts commit ec842ef on PR #332.

Still need to add support in Go, which will involve treating a lot of stuff as pointers, and checking that the postgres bindings support that (how else can you set stuff to null/non-null dynamically?).

This reverts commit ec842ef on PR #332.
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 16, 2020

Codecov Report

Merging #333 into develop will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #333   +/-   ##
========================================
  Coverage    99.01%   99.02%           
========================================
  Files          135      135           
  Lines         2857     2860    +3     
  Branches        43       46    +3     
========================================
+ Hits          2829     2832    +3     
  Misses          28       28           
Impacted Files Coverage Δ
src/main/scala/temple/DSL/semantics/Analyzer.scala 100.00% <100.00%> (ø)
...rc/main/scala/temple/DSL/semantics/Validator.scala 100.00% <100.00%> (ø)
...rc/main/scala/temple/builder/DatabaseBuilder.scala 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bae2ddc...dd08e4e. Read the comment docs.

@c-harding c-harding mentioned this pull request Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant