Open
Conversation
As they will never be reached, they're not included in compilation and can be safely removed.
StrangerCoug
force-pushed
the
code-cleanup
branch
3 times, most recently
from
c30d283 to
910620d
Compare
These have the same code in super and are not overridden, so they can be deleted.
This simplifies stuff that can be replaced with constants and gets rid of redundant initializers and assignments.
StrangerCoug
force-pushed
the
code-cleanup
branch
from
8d0b876 to
91af236
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few more places we can clean up the Java code.