Make MTProxy compatible with non-glibc systems #443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the version 10 of GCC they changed the default from `-fcommon` to `-fno-common`. The MTProxy object files share some global vars defined in `common/*.c` so it's required to provide the option to the compiler. https://www.gnu.org/software/gcc/gcc-10/changes.html
It makes it possible to compile MTProxy on Alpine Linux.
Puma2022
approved these changes
Jan 5, 2022
Puma2022
approved these changes
Jan 5, 2022
wention
added a commit
to wention/MTProxy
that referenced
this pull request
Mar 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MTProxy relies on some specific glibc features that not every libc supports. So if one wants to compile it on Alpine Linux some tweaks are required. I successfully compiled MTProxy with musl libc by doing the following:
backtracefunction is non-standard. Uselibexecinfoport if it's available in the system.lrand48_r,mrand48_r,drand48_r,rand48_rto their standard counterparts.-fcommonoption to fix the build on the latest GCC versions.