Simplify requestPermissionBackgroundLocation and requestPermissionBatteryOptimization responses#256
Closed
ieduardogf wants to merge 1 commit intomasterfrom
Closed
Simplify requestPermissionBackgroundLocation and requestPermissionBatteryOptimization responses#256ieduardogf wants to merge 1 commit intomasterfrom
ieduardogf wants to merge 1 commit intomasterfrom
Conversation
…teryOptimization responses Remove `settings_change_required` from both methods' response types, returning only `status: "granted" | "denied"` as agreed with iOS and Android teams. Closes #255 Made-with: Cursor
Collaborator
Author
|
We did another test with AI here #257 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #255
requestPermissionBackgroundLocation: Response simplified fromstatus: "granted" | "denied" | "settings_change_required"tostatus: "granted" | "denied". Thesettings_change_requiredvalue was not used by iOS.requestPermissionBatteryOptimization: Response simplified fromstatus: "denied" | "settings_change_required"tostatus: "granted" | "denied", aligning with the Android implementation.Changes
src/post-message.ts: Updated response payload typessrc/family-locator.ts: Updated function return typessrc/__tests__/family-locator-test.ts: Updated test assertionsREADME.md: Updated documented type signaturesCHANGELOG.md: Added v4.2.0 entryTest plan
yarn cipasses (prettier, lint, ts-check, tests, build)granted/deniedresponses work for both methods