feat(skin): Add backgroundContainerNegativeOverNegative #2564
Draft
aweell wants to merge 4 commits intoproductionfrom
Draft
feat(skin): Add backgroundContainerNegativeOverNegative #2564aweell wants to merge 4 commits intoproductionfrom
aweell wants to merge 4 commits intoproductionfrom
Conversation
8 tasks
aweell
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning
Do not merge this PR until spacing alignment project is merged in web, in order to avoid more screenshot changes
Pull Request Description: feat(skin): Add backgroundContainerNegativeOverNegative
Motivation:
This pull request introduces a new color token,
backgroundContainerNegativeOverNegative, to enhance our design system. The addition of this token addresses the need for a consistent and visually appealing background color that can be used in negative contexts, particularly in dark mode.Improvements:
Enhanced Theme Support: By adding
backgroundContainerNegativeOverNegative, we provide designers and developers with a dedicated color option that maintains visual consistency when layering elements in UI designs, especially in dark mode scenarios.Increased Flexibility: This new color token allows for greater flexibility in design implementations, enabling developers to create more sophisticated and nuanced user interfaces.
Consistency Across Platforms: The updates are made across multiple JSON files, ensuring that the new token is available in various themes and platforms, thus maintaining consistency in our design language.
Documentation: Each new token is documented with a description, making it easy for team members to understand its purpose and application.
This change ultimately enhances our design system, providing more robust tools for creating visually appealing and accessible user interfaces.