Just swap recorded and golden line numbers in reports#10
Merged
nimeacuerdo merged 1 commit intomainfrom Sep 17, 2025
Merged
Conversation
…ogs in the final report
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR swaps the order of "recorded" and "golden" in error messages to match the visual layout in the final report where golden logs appear on the left and recorded logs appear on the right.
- Updates error message format to display golden before recorded values
- Ensures consistency between error message order and visual report layout
Comments suppressed due to low confidence (1)
loggerazzi/src/main/java/com/telefonica/loggerazzi/LogComparator.kt:18
- For consistency with the updated size mismatch message format, this line should also swap the order to show golden before recorded:
\"Different line at index $i: golden=${golden[i]}, recorded=${recorded[i]}\"
compareResult.appendLine("Different line at index $i: recorded=${recorded[i]}, golden=${golden[i]}")
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
dnieto-r
approved these changes
Sep 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🥅 What's the goal?
Just swap recorded and golden line numbers in report to match their logs in the final report and avoid my (only me?) TOC with this, were golden logs are listed on the left and record on the right, whereas the message has the opposite order :)
📘 Documentation changes?