Add Visual Studio requirement for Windows in the README#9
Open
iceberg53 wants to merge 1 commit intoTejasQ:mainfrom
Open
Add Visual Studio requirement for Windows in the README#9iceberg53 wants to merge 1 commit intoTejasQ:mainfrom
iceberg53 wants to merge 1 commit intoTejasQ:mainfrom
Conversation
This commit highlights the need for Windows users to have Visual Studio including the "Desktop development with C++" workload already installed before trying to get gen-subs on their computer. Otherwise, when that requirement is not met, you get an error to node-gyp requirements on Windows. See https://github.com/nodejs/node-gyp#on-windows
|
Great, that helped me. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit highlights the need for Windows users to have Visual Studio including the "Desktop development with C++" workload already installed before trying to get gen-subs on their computer.
Otherwise, when that requirement is not met, you get an error due to node-gyp requirements on Windows.
See https://github.com/nodejs/node-gyp#on-windows