Open
Conversation
Add explicitly the shell command to run for installing gen-subs to make it easier for those new to the nodejs ecosystem.
This commit mainly replaces the use of custom string manipulation by
functions from the path module from node ( path.basename(),
path.resolve(), path.extname(), ...) .
It's done to account for Windows OS file paths
("C:\\folder\\subfolder\\file.ext") which are different from POSIX ones
("/home/user/folder/file.ext") .
That difference led to file names with character sequences that caused
an error when calling ffmpeg.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
That's a fix for the issue FFMPEG exits with code 1 - Invalid Argument.
It introduces the use of functions from the path module (path.basename(), path.resolve(), path.extname(), ...) for handling file paths correctly for both Windows and POSIX operating systems.
The previous implementation fed file paths with invalid characters sequences when running on Windows which caused the bug.