Allow Items with custom NBT to be added in special.yml #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (upperItemName.startsWith("LIGHT") && !upperItemName.equals("LIGHT")) { | ||
| int level; | ||
| try { | ||
| level = Integer.parseInt(itemName.split("-")[1]); |
There was a problem hiding this comment.
Can we replace this with JSON configurations for all lighting levels? Now it is possible.
Author
There was a problem hiding this comment.
Implemented in the new commit
| final Material itemMaterial; | ||
| try { | ||
| itemMaterial = Material.valueOf(itemName); | ||
| if (itemName.contains(" ")) { |
There was a problem hiding this comment.
Perhaps it is cleaner if not only a space is used, but a ", " is used as a separator.
- 'ITEM_FRAME, {...'
Author
There was a problem hiding this comment.
Implemented in the new commit
| - 'ITEM_FRAME {"minecraft:entity_data": {id: "minecraft:item_frame", Invisible: 1b}, "minecraft:custom_name":''{text:"Invisible Item Frame"}''}' | ||
|
|
||
| # No touch! | ||
| version: 1 |
There was a problem hiding this comment.
Does the version need to be incremented? (Tbd.)
Owner
|
Thanks for the PR! I'll give it a full review once it's out of draft. |
…g unnecessary locale conversion
…g and simplify item parsing
|
Thank you! I confirm that the changes are good. |
Author
|
(I just realized that the relocation of item-nbt-api didnt work, fixed it) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to allow the use of custom nbt items to be added in the special.yml file, utilizing the NBTAPI.
The build.gradle.kts has also been changed with updated versions and repositories, so that the project can be built again.
This fixes #71
Image of a new item with custom nbt in the menu:
