2025 Redesign #184
2025 Redesign #184
Conversation
* Fresh install of 11ty * Basic CSS, page content, and RSS * import blog posts * Remove unused files
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| module.exports = async function() { | ||
| try { | ||
| const response = await fetch('https://rss.beehiiv.com/feeds/vZHlctjmDk.xml'); | ||
| const xml = await response.text(); |
There was a problem hiding this comment.
HTTP errors silently ignored in newsletter data fetch
Medium Severity
The fetch() call doesn't check response.ok or response.status before processing the response. The Fetch API doesn't throw exceptions for HTTP error responses (4xx, 5xx) - only for network failures. If the beehiiv RSS server returns a 404 or 500 error, the code will attempt to parse the error page as XML, find no items, and silently return an empty issues array. The catch block only catches network errors, not HTTP errors, so there's no logging or indication when the feed server returns an error status.
| <script src="{{ '/assets/js/bundle.js' | url }}"></script> | ||
| {% if highlightjs %} | ||
| <script src="//cdnjs.cloudflare.com/ajax/libs/highlight.js/10.7.2/highlight.min.js"></script> | ||
| <script>hljs.initHighlightingOnLoad();</script> |
There was a problem hiding this comment.
Syntax highlighting removed but posts still expect it
Medium Severity
The redesigned default.njk template removes the conditional highlight.js loading ({% if highlightjs %}...{% endif %}), but several posts still have highlightjs: true in their frontmatter (e.g., src/posts/2014-05-13-jerseyscript.md, src/posts/2020-01-02-my-first-interactive-email.md, src/work/2016-01-01-canfield.md, src/work/2020-01-01-stack-overflow.md). Code blocks in these posts will render without syntax highlighting, causing a visual regression.
And make article list CSS names more generic
| /* Utility Classes */ | ||
| .text-mono { font-family: var(--font-mono); } | ||
| .text-muted { color: var(--color-text-muted); } | ||
| .text-secondary { color: var(--color-text-secondary); } |
There was a problem hiding this comment.
CSS variable used but never defined
Medium Severity
The CSS variable --color-text-secondary is referenced in multiple places (.text-secondary utility class, .caption, .post-content blockquote, and .btn) but is never defined in the :root block. Elements using the text-secondary class in templates like 404.njk, default.njk, and post.njk will not receive the intended muted text color, instead falling back to inherited colors. The variable --color-text-muted is defined and appears to be the intended equivalent.
Note
Major redesign and build simplification with Eleventy 3 and custom CSS.
default.njk,post.njk) and simplified 404; remove legacy header/footer partials and iconsreadableDatefilter (Luxon v3) and HTML minification transform that skips XML/RSSsrc/_data/newsletter.jsto fetch Beehiiv RSS; adjust site data; remove unused tag collections/filesdublin.rdfWritten by Cursor Bugbot for commit 563d923. This will update automatically on new commits. Configure here.