project-auth #330
Open
project-auth #330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HIPPIEKICK
approved these changes
May 27, 2024
Contributor
HIPPIEKICK
left a comment
HIPPIEKICK
left a comment
There was a problem hiding this comment.
You've successfully created a working authentication app, well done! 🚀
Comment on lines
+66
to
+74
| if (!name) { | ||
| return res.status(400).json({ error: "Name is required" }); | ||
| } | ||
| if (!email) { | ||
| return res.status(400).json({ error: "Email is required" }); | ||
| } | ||
| if (!password) { | ||
| return res.status(400).json({ error: "Password is required" }); | ||
| } |
|
|
||
| // Login endpoint to authenticate a user | ||
| // Find the user by email, if user is found and password is correct, generate and return an access token | ||
| app.post("/login", async (req, res) => { |
Contributor
There was a problem hiding this comment.
This could be named /sessions to follow REST naming principles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Netlify link
Backend: https://project-auth-0pi0.onrender.com/
Frontend: https://cheerful-froyo-159f59.netlify.app/
Collaborators
Solo