Dev

[RandithaK]

Summary by CodeRabbit

• New Features

  • Database preflight validation now runs at startup to verify connectivity before Spring context initialization
  • Email feature enabled by default with health monitoring

• Configuration

  • Broadened authorization for employee creation endpoint to support both ADMIN and SUPER_ADMIN roles

• Chores

  • Removed unused dotenv dependency and .env file loading mechanism

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request removes the dotenv dependency and its initialization logic, enables the database preflight check, broadens employee endpoint authorization to include SUPER_ADMIN role, and enables email feature with health checks by default. Formatting cleanup applied to AuthService.

Changes

Cohort / File(s)	Summary
Database Preflight Configuration src/main/resources/META-INF/spring.factories	Enabled DatabasePreflightInitializer by uncommenting the org.springframework.context.ApplicationContextInitializer registration.
Dotenv Dependency Removal auth-service/pom.xml, auth-service/src/main/java/com/techtorque/auth_service/AuthServiceApplication.java	Removed io.github.cdimascio:dotenv-java dependency from pom.xml and eliminated dotenv initialization logic from the main method startup sequence.
Authorization Enhancement auth-service/src/main/java/com/techtorque/auth_service/controller/AuthController.java	Broadened /users/employee (createEmployee) endpoint authorization condition from requiring ADMIN role to accepting either ADMIN or SUPER_ADMIN.
Email Feature Enablement auth-service/src/main/resources/application.properties	Enabled email feature by setting app.email.enabled to true and activated mail health check by setting management.health.mail.enabled to true with binding to EMAIL_ENABLED.
Code Formatting auth-service/src/main/java/com/techtorque/auth_service/service/AuthService.java	Whitespace and formatting adjustments around refreshToken method; no functional logic changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10–15 minutes

• Verify database preflight initialization doesn't cause unintended startup delays or failures
• Confirm dotenv removal is intentional and no environment-based configuration is inadvertently lost
• Validate SUPER_ADMIN role addition to authorization is aligned with system security design

Poem

🐰 A preflight hop before we spring,
Dotenv gone—a lighter thing!
Email's dancing through the air,
SUPER_ADMIN gets their share,
Config clean and bright we go! ✨

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch dev

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4b66c0b and 7ee577f.

📒 Files selected for processing (6)

• DATABASE_PREFLIGHT_ENABLED.md (1 hunks)
• auth-service/pom.xml (0 hunks)
• auth-service/src/main/java/com/techtorque/auth_service/AuthServiceApplication.java (0 hunks)
• auth-service/src/main/java/com/techtorque/auth_service/controller/AuthController.java (1 hunks)
• auth-service/src/main/java/com/techtorque/auth_service/service/AuthService.java (1 hunks)
• auth-service/src/main/resources/application.properties (1 hunks)

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Copilot]

Pull Request Overview

This PR makes several configuration and infrastructure improvements to the authentication service, including enabling email functionality by default, removing the dotenv dependency in favor of native environment variable handling, and documenting the database preflight check feature.

Key changes:

• Email functionality is now enabled by default with dynamic health check configuration
• Dotenv library removed in favor of standard Spring Boot environment variable handling
• Authorization rules expanded to include SUPER_ADMIN role for employee creation endpoint

Reviewed Changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
auth-service/src/main/resources/application.properties	Enables email by default and makes mail health check dynamic based on EMAIL_ENABLED
auth-service/src/main/java/com/techtorque/auth_service/service/AuthService.java	Whitespace cleanup (trailing whitespace removal)
auth-service/src/main/java/com/techtorque/auth_service/controller/AuthController.java	Adds SUPER_ADMIN to authorization for employee creation endpoint
auth-service/src/main/java/com/techtorque/auth_service/AuthServiceApplication.java	Removes dotenv initialization code
auth-service/pom.xml	Removes dotenv-java dependency
DATABASE_PREFLIGHT_ENABLED.md	Adds documentation for database preflight check feature

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The mail health check default value should be false, not true. When EMAIL_ENABLED is not set, it defaults to true on line 49, but the health check on line 51 also defaults to true, which will cause health check failures if mail credentials are not configured. Based on the comment on line 39 indicating email is disabled by default in development, and the EmailService.java having @Value(\"${app.email.enabled:false}\") as its default, the health check should align with a false default to prevent startup issues when mail is not configured.

Suggested change

	management.health.mail.enabled=${EMAIL_ENABLED:true}
	management.health.mail.enabled=${EMAIL_ENABLED:false}

[Copilot]

The default value for app.email.enabled has changed from false to true, but this contradicts the comment on line 39 which states 'for development, email is disabled by default'. Additionally, the EmailService.java file uses @Value(\"${app.email.enabled:false}\") with a false default, creating an inconsistency. Consider either updating the comment to reflect the new default or changing the default back to false to maintain consistency with the service layer and the documented development behavior.

Suggested change

	app.email.enabled=${EMAIL_ENABLED:true}
	app.email.enabled=${EMAIL_ENABLED:false}