Skip to content
This repository was archived by the owner on Nov 23, 2025. It is now read-only.

fix: Update yq command to only target Deployment resource#9

Merged
RandithaK merged 1 commit intomainfrom
devOps
Nov 7, 2025
Merged

fix: Update yq command to only target Deployment resource#9
RandithaK merged 1 commit intomainfrom
devOps

Conversation

@RandithaK
Copy link
Copy Markdown
Member

@RandithaK RandithaK commented Nov 7, 2025

  • Use select(.kind == "Deployment") to ensure yq only modifies the Deployment
  • Prevents accidental modification of Service resource in multi-document YAML
  • Fixes CI/CD failure caused by invalid Service fields

Summary by CodeRabbit

  • Bug Fixes
    • Enhanced deployment reliability by implementing more precise container image updates that target only Deployment resources, preventing unintended changes to other configurations.

- Use select(.kind == "Deployment") to ensure yq only modifies the Deployment
- Prevents accidental modification of Service resource in multi-document YAML
- Fixes CI/CD failure caused by invalid Service fields
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Nov 7, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

The deployment workflow's yq command is refined to selectively update container images only in Deployment resources by adding a select(.kind == "Deployment") filter, preventing unintended modifications to non-Deployment manifest objects.

Changes

Cohort / File(s) Summary
Workflow manifest update
.github/workflows/deploy.yaml
Refined yq in-place update to target Deployment objects exclusively using conditional selection filter, confining image updates to Deployment resources only

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

  • Verify yq syntax correctness for the select(.kind == "Deployment") conditional
  • Confirm the filter properly isolates image updates to Deployment objects without affecting other manifest kinds
  • Ensure the image path reference remains accurate post-modification

Poem

🐰 A rabbit hops through deployment files with care,
"Select only Deployments," we declare!
No stray updates shall roam free,
With filters precise, our manifests stay worry-free,
Now pipelines run just right everywhere! 🚀

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch devOps

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8cfca0d and 1eb3945.

📒 Files selected for processing (1)
  • .github/workflows/deploy.yaml (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@RandithaK RandithaK merged commit 3cbfd5a into main Nov 7, 2025
4 of 5 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant