Bug/fix fft implemenation #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… FFT arguements that were incorrectly capitalised; define LED matrix setup for WS2812B strip
Removed unused debugging variables. Replace dark implementation of brightness with value of 0x000000 (black).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The arduino-fft implementation required a few fixes to get running. Mostly capitalisation typos and instatiation of the FFT object. Setting LEDs to dark has also been updated from a brightness implementation to a value implementation. Any LED that needs to go dark will be set to 0x000000 (RGB(0,0,0) = black). Some minor edits to comments are also present to help understand what the code is doing.