Skip to content

moved ip config to .env file, added extra hosts for easy url acsess#73

Open
mipdableep wants to merge 3 commits intoTechHutTV:mainfrom
mipdableep:main
Open

moved ip config to .env file, added extra hosts for easy url acsess#73
mipdableep wants to merge 3 commits intoTechHutTV:mainfrom
mipdableep:main

Conversation

@mipdableep
Copy link

now edits to the .env ip adresses will be applied automaticly, and it will be possible to acsess services via their names, ie: https://sonar/

@TechHutTV
Copy link
Owner

Awesome will test this within the next few days

@mipdableep
Copy link
Author

it is very possible that this is a bit too much, but i made some default configs for the env vars and basic service settings that services can inherit and overwrite, instead of duplicating the settings across the file

@TechHutTV
Copy link
Owner

TechHutTV commented Mar 19, 2026

Hey, thanks for putting this together! I like the idea of moving the IPs into the .env file.

A few things before we could move forward with this:

Syntax issues - There are =: typos in the environment mappings that would break the compose file:

  • PUID=: should be PUID:
  • WEBUI_PORT=: should be WEBUI_PORT:
  • TORRENTING_PORT=: should be TORRENTING_PORT:

extra_hosts - Docker Compose already handles DNS resolution between containers on the same network by container name, so the extra_hosts block is mostly redundant here.

YAML anchors - I appreciate the DRY approach, but since this repo is meant to be beginner-friendly, the anchor/merge key pattern adds a layer of indirection that makes the file harder to follow. I'd prefer keeping each service definition explicit so people can read it top to bottom without needing to understand YAML anchors.

I think the .env IP extraction on its own would be a solid, focused improvement. Would you be open to slimming this down to just that part?

now edits to the .env ip adresses will be applied automaticly, and it
will be possible to acsess services via their names, ie: https://sonar/
@mipdableep
Copy link
Author

i belive i fixed it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants