moved ip config to .env file, added extra hosts for easy url acsess#73
moved ip config to .env file, added extra hosts for easy url acsess#73mipdableep wants to merge 3 commits intoTechHutTV:mainfrom
Conversation
|
Awesome will test this within the next few days |
|
it is very possible that this is a bit too much, but i made some default configs for the env vars and basic service settings that services can inherit and overwrite, instead of duplicating the settings across the file |
|
Hey, thanks for putting this together! I like the idea of moving the IPs into the A few things before we could move forward with this: Syntax issues - There are
extra_hosts - Docker Compose already handles DNS resolution between containers on the same network by container name, so the YAML anchors - I appreciate the DRY approach, but since this repo is meant to be beginner-friendly, the anchor/merge key pattern adds a layer of indirection that makes the file harder to follow. I'd prefer keeping each service definition explicit so people can read it top to bottom without needing to understand YAML anchors. I think the |
now edits to the .env ip adresses will be applied automaticly, and it will be possible to acsess services via their names, ie: https://sonar/
|
i belive i fixed it |
now edits to the .env ip adresses will be applied automaticly, and it will be possible to acsess services via their names, ie: https://sonar/