Skip to content

Conversation

@Ignaci09
Copy link
Contributor

@Ignaci09 Ignaci09 commented Jul 4, 2025

Sent test and train reports into their corresponding pickle files because names of the files were swapped.

Description

The test report and train report are correctly sent into their corresponding pickles.

Motivation and Context

The test report was being sent into the training report pickle and viceversa. Now they are correctly assigned into their corresponding pickles.

How has this been tested?

I ran:
the makefile
with no errors
make clean
with no errors
pylint --rcfile=pylintrc teaspoon/teaspoon/ML/PD_Classification.py
with many errors about pylint having evolved, and the Camelcase; thus getting a low mark (0.56/10), but I just swapped a couple of names so I don't think the style has changed.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • My code follows the code style of this project. (make clean)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (make html)
  • I have incremented the version number in the pyproject.toml file.
  • I have added tests to cover my changes.
  • All new and existing tests passed. (make tests)

Ignaci09 and others added 2 commits July 4, 2025 13:22
Sent test and train reports into their corresponding pickle files because names of the files were switched.
@lizliz lizliz self-requested a review July 28, 2025 15:38
Copy link
Collaborator

@lizliz lizliz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Nice catch, thank you @Ignaci09!

@lizliz lizliz merged commit 850bfc7 into TeaspoonTDA:master Jul 28, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants