-
Notifications
You must be signed in to change notification settings - Fork 0
Feat: 경험정리 수정 API 구현 (#74) #92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @IISweetHeartII, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 이 PR은 기존 경험 정리 데이터를 업데이트할 수 있는 기능을 도입합니다. 사용자는 이제 경험 정리의 제목이나 희망 직무를 수정할 수 있으며, 이는 서비스의 유연성을 높이고 사용자 경험을 개선하는 데 기여합니다. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
이 PR은 경험 정리 수정 API를 추가합니다. 감사된 파일에서 특정 취약점은 발견되지 않았습니다. 전반적으로 아키텍처와 스타일 가이드를 잘 따르고 있으나, ExperienceService의 업데이트 로직에서 불필요한 데이터베이스 연산을 줄여 효율성을 높일 수 있는 개선점이 발견되었습니다.
Summary
경험정리 수정(PATCH) API를 추가해 기존 경험정리 데이터를 업데이트할 수 있도록 구현했습니다.
Changes
PATCH /experiences/:id엔드포인트 추가Type of Change
해당하는 항목에 체크해주세요:
Target Environment
배포 대상 브랜치를 선택해주세요:
dev)main)Related Issues
관련 이슈를 연결해주세요:
Testing
테스트 방법을 작성해주세요:
pnpm run lint통과pnpm run build통과pnpm exec jest --passWithNoTests통과Checklist
PR 생성 전 확인사항:
docs/development/CODE_STYLE.md)docs/development/GIT_CONVENTIONS.md)docs/development/NAMING_CONVENTIONS.md)pnpm run build)pnpm run lint)Screenshots (Optional)
N/A
Additional Notes
TransformInterceptor 응답 컨벤션 및 Service 계층 예외 처리 규칙을 준수했습니다.