-
Notifications
You must be signed in to change notification settings - Fork 0
Feat: 회사별 인사이트 조회 API 구현 (#42) #90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @IISweetHeartII, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 이 PR은 회사별 인사이트 데이터를 조회하기 위한 새로운 기능을 도입합니다. 기존 PortfolioCorrection 엔티티를 활용하여 특정 회사 ID에 해당하는 인사이트 정보를 효율적으로 가져올 수 있도록 API, 서비스, DTO 계층에 걸쳐 필요한 로직을 구현했습니다. 이를 통해 사용자들은 회사별 인사이트를 쉽게 확인할 수 있게 됩니다. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
이 PR은 회사별 인사이트 조회 API를 구현합니다. 새로운 API 엔드포인트가 추가되었으나, 이에 대한 단위 테스트나 E2E 테스트 코드가 누락되었습니다. 레포지토리 스타일 가이드의 '우선순위 중간' 항목인 '테스트 누락'에 해당하므로, 코드 안정성과 유지보수성 향상을 위해 테스트 코드를 추가하는 것을 권장합니다.
src/modules/portfolio-correction/application/dtos/company-insight.dto.ts
Show resolved
Hide resolved
|
Correction note (formatted):
Verification:
|
Summary
회사별 인사이트 조회 API를 추가해 회사 ID 기준 인사이트 데이터를 조회할 수 있도록 구현했습니다.
Changes
GET /portfolio-correction/company-insights/:companyId엔드포인트 추가Type of Change
해당하는 항목에 체크해주세요:
Target Environment
배포 대상 브랜치를 선택해주세요:
dev)main)Related Issues
관련 이슈를 연결해주세요:
Testing
테스트 방법을 작성해주세요:
pnpm run lint통과pnpm run build통과pnpm exec jest --passWithNoTests통과Checklist
PR 생성 전 확인사항:
docs/development/CODE_STYLE.md)docs/development/GIT_CONVENTIONS.md)docs/development/NAMING_CONVENTIONS.md)pnpm run build)pnpm run lint)Screenshots (Optional)
N/A
Additional Notes
도메인 계층 분리를 유지하며 조회 전용 로직으로 구현했습니다.