-
Notifications
You must be signed in to change notification settings - Fork 0
Chore: Redis 모듈 기본 세팅 및 문서화 (#64) #88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @IISweetHeartII, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 이 PR은 SMS 인증 및 리프레시 토큰 저장을 위한 Redis 인프라의 기본 모듈을 설정합니다. 환경 변수를 통해 Redis 연결을 구성하고, 애플리케이션 전반에서 Redis 서비스를 쉽게 사용할 수 있도록 NestJS 모듈을 통합합니다. 또한, Redis 설정 및 운영에 대한 상세한 문서를 제공하여 향후 개발 및 배포를 용이하게 합니다. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Ignored Files
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
Redis 모듈 추가 및 설정에 대한 리뷰입니다. 전반적으로 잘 구성되었으나, 두 가지 개선점을 제안합니다. 첫째, Redis 설정 파일의 재시도 로직에 있는 매직 넘버를 상수로 추출하여 가독성과 유지보수성을 높이는 것을 권장합니다. 둘째, RedisService가 ioredis 클라이언트를 직접 노출하는 대신, 필요한 명령어들을 메서드로 추상화하여 결합도를 낮추는 장기적인 개선 방향을 제안합니다.
Summary
SMS 인증/리프레시 토큰 저장을 위한 Redis 인프라 기본 모듈을 추가하고 환경 변수 기반 설정 및 운영 문서를 정리했습니다.
Changes
ioredis의존성 추가RedisConfigService추가 (REDIS_HOST/PORT/PASSWORD/DB기반 옵션 생성)RedisModule및RedisService추가 (DI 토큰 포함)AppModule에 Redis 모듈 등록.env.example에 Redis 설정 변수 추가docs/infrastructure/REDIS.md문서 추가 (설정/배포/사용 가이드)Type of Change
Target Environment
dev)main)Related Issues
Testing
실행 결과:
pnpm run lint: 통과pnpm run build: 통과 (TSC 0 issues)pnpm exec jest --passWithNoTests: No tests found, code 0Checklist
docs/development/CODE_STYLE.md)docs/development/GIT_CONVENTIONS.md)docs/development/NAMING_CONVENTIONS.md)pnpm run build)pnpm run lint)Screenshots (Optional)
N/A
Additional Notes