Show date of expiry for generated keys & ensure clean response is only returned. #926
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…i-key`to maintain security & safety, for readablity shifted expiry-options to `constants.js` from `dashboard.jsx`
…that-are-about-to-expire-ensure-good-shaped-response' of github.com:TeamShiksha/openlogo into 925-show-date-of-expiry-of-api-warn-enduser-about-keys-that-are-about-to-expire-ensure-good-shaped-response
|
printgourav
requested review from
AryaDharkar,
Sumitgitup and
sachinkmrsin
and removed request for
sachinkmrsin
aps08
requested review from
sachinkmrsin
and removed request for
AryaDharkar and
Sumitgitup
sachinkmrsin
approved these changes
Jan 4, 2026
Member
sachinkmrsin
left a comment
sachinkmrsin
left a comment
There was a problem hiding this comment.
Looks good to me. Pr follows coding standards.
printgourav
changed the title
getUserDataController does not consist of API keys.
printgourav
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes #925
This PR improves Ux for user by showing expiration dates in a table with warnings when keys are about to expire also it consist of backend changes done to ensure clean response is being sent to user without containing anything sensitive information about API key which is meant to be shown only when created .
What type of PR is this? (Check all applicable)
Screenshots.
Frontend
The UI enhancement makes API Key that would expire expire very soon user, get warn with red
Frontend test
Coverage for Frontend
Backend
The response sent now does not consist of sensitive info about keys.
Existing backend test are running fine.
Coverage of backend
Checklist