Conversation
Co-authored-by: lincoltd7 <117526452+lincoltd7@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Improve badge usability in simulator
Skip EEPROM programming prompt when running in the simulator
Feb 27, 2026
Co-authored-by: lincoltd7 <117526452+lincoltd7@users.noreply.github.com>
Copilot
AI
changed the title
Skip EEPROM programming prompt when running in the simulator
Fix simulator compatibility: SyntaxWarning and Timer ImportError
Feb 28, 2026
Co-authored-by: lincoltd7 <117526452+lincoltd7@users.noreply.github.com>
…ne call in __init__ Co-authored-by: lincoltd7 <117526452+lincoltd7@users.noreply.github.com>
Copilot
AI
changed the title
Fix simulator compatibility: SyntaxWarning and Timer ImportError
Fix simulator compatibility: string identity comparison, missing Timer import, unawaited coroutine
Feb 28, 2026
There was a problem hiding this comment.
Pull request overview
Improves BadgeBotApp compatibility in the badge simulator by removing simulator-only runtime failures and warnings, while keeping behavior on real badge hardware effectively unchanged.
Changes:
- Fixes incorrect string identity comparison (
is→==) when locating the HexDrive app. - Makes
machine.Timerimport optional and disables timer-driven stepping when unavailable (simulator). - Skips EEPROM “programming needed” flow in the simulator when no real EEPROM hardware exists.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…eate_task() Co-authored-by: lincoltd7 <117526452+lincoltd7@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
is→==for string comparison infind_hexdrive_appmachine.Timerimport optional with graceful fallback toNoneRuntimeWarning: coroutine '_gain_focus' was never awaited: useasyncio.get_event_loop().create_task()instead ofasyncio.create_task(), which works even when no event loop is currently running (e.g. in smoke tests / synchronous contexts)Original prompt
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.