Allow for valid hibernate environment variables #817
Conversation
FireMasterK
left a comment
FireMasterK
left a comment
There was a problem hiding this comment.
How would this work for configuration properties that have a _ such as hibernate.connection.handling_mode for example?
|
@FireMasterK Given that sort of variable isn't sensitive, I don't image many people would use an environment variable to set it. However, we could swap out a single underscore for a double underscore in the env variable names. |
Yes I think that would be a reasonable workaround! |
|
@FireMasterK Could I get a review on this? |
*nix systems can't have periods in their environment variable names, so we instead look for `HIBERNATE` prefixes, then lowercase and translate underscores to periods. This will allow for better compatibility with *nix systems when configuring likely sensitive hibernate values.
Head branch was pushed to by a user without write access
|
Rebased onto master, should be all good now? |
2 participants
*nix systems can't have periods in their environment variable names, so we instead look for
HIBERNATEprefixes, then lowercase and translate underscores to periods. This will allow for better compatibility with *nix systems when configuring likely sensitive hibernate values.