fix: calendar reminder timezone handling#211
Open
realmpastai-web wants to merge 1 commit intoTeamNovaSoft:devfrom
Open
fix: calendar reminder timezone handling#211realmpastai-web wants to merge 1 commit intoTeamNovaSoft:devfrom
realmpastai-web wants to merge 1 commit intoTeamNovaSoft:devfrom
Conversation
Fixes TeamNovaSoft#109 ## Problem The issue was that cron expressions were generated using the server's local timezone (getHours/getMinutes), but the CronJob was scheduled with the event's timezone. This caused a mismatch when events were in different timezones than the server. ## Changes - Added dateToCronExpressionInTimezone() helper function that uses Intl.DateTimeFormat to extract date components in the event's timezone - Updated scheduleEventNotification() to use the timezone-aware function - Added comprehensive tests for timezone handling ## Testing - Before: Event at 1pm Argentina scheduled reminder for 1pm Colombia (2h late) - After: Event at 1pm Argentina correctly schedules reminder for 1pm Argentina /claim TeamNovaSoft#109
Author
|
Hi @maintainer, this PR retargets to dev branch as requested. Ready for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #109
Problem
The issue was that cron expressions were generated using the server's local timezone (getHours/getMinutes), but the CronJob was scheduled with the event's timezone. This caused a mismatch when events were in different timezones than the server.
Changes
Testing
Note: This PR replaces #210 which was targeting the wrong branch (main instead of dev).
/claim #109