Feat/iss 30/poll votation message update#208
Merged
Israel-Laguan merged 7 commits intodevfrom Jul 10, 2025
Merged
Conversation
src/config.js
Outdated
| boostedPointTagId: | ||
| process.env.ADD_BOOSTED_POINT_TAG_ID || '1263873487953592381', | ||
| }, | ||
| operationMode: process.env.OP_MODE || 'max', |
Contributor
There was a problem hiding this comment.
For the ENV this name is weird, what about is something like 'VOTE_DRAW_MODE'
| for (const pollAnswer of pollAnswers.values()) { | ||
| if (pollAnswer.voteCount > maxVoteCount) { | ||
| maxVoteCount = pollAnswer.voteCount; | ||
| topVoted.length = 0; |
Contributor
There was a problem hiding this comment.
why is this one needed?
Collaborator
Author
There was a problem hiding this comment.
Sorry which one do you mean?
Contributor
There was a problem hiding this comment.
Why set the length to 0?
Collaborator
Author
There was a problem hiding this comment.
to reset the array when a new higher values is found
Contributor
There was a problem hiding this comment.
hmm try to reset like topVoted = []
|
|
||
| module.exports = { | ||
| name: Events.MessageUpdate, | ||
| async execute(_client, message) { |
Contributor
There was a problem hiding this comment.
Why the underscore in client? Maybe use just 'client' as name for the param?
| } | ||
| } | ||
|
|
||
| return topVoted.length > 0 ? topVoted : [maxVoteCount]; |
Contributor
There was a problem hiding this comment.
Try to modify the function so always returns the top pollAnswer
now it return one answer OR an array, is confusing
Israel-Laguan
approved these changes
Apr 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces the following:
MessageUpdate.Benefits:
Type of change
Checklist
This issue can be closed when the following tasks are complete:
How to test
/vote-pointscommandScreenshots